fix(recordings): use safe recording close on cleanup #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-triage
andrewazores
removed
the
needs-triage
|
/build_test |
|
Workflow started at 1/2/2025, 10:55:42 AM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ |
Josh-Matsuoka
approved these changes
Jan 9, 2025
andrewazores
force-pushed
the
recording-safe-close
branch
from
b186263 to
161a626
Compare
|
/build_test |
|
Workflow started at 1/10/2025, 9:07:59 AM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #760
Description of the change:
safeCloseRecordingmethod in two places where it wasn't before. Without this, any target connection failure would throw an exception and cause an early return from the callsites, which could lead to unexpected behaviour like orphaned resources left behind. This is the real fix.INFOlevel toALLin all cases, but I found that this actually interfered with the smoketest operation at times due to the extremely high verbosity - actions like archiving recordings actually saw a performance degradation because every byte written out by Cryostat would be logged, which drastically slowed the I/O and could cause operations to time out.Motivation for the change:
This change is helpful because users may want to...
How to manually test:
./smoketest.bash -Ot(pass-vone or two times to enable verbose logging)