Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): add option to disable hostname verification #776

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Jan 14, 2025

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #707

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@mergify mergify bot added the safe-to-test label Jan 14, 2025
@ebaron ebaron added the feat New feature or request label Jan 14, 2025
@ebaron ebaron force-pushed the agent-disable-hostname-verify branch from c0df125 to 7fa6124 Compare January 15, 2025 21:45
@ebaron ebaron force-pushed the agent-disable-hostname-verify branch from 7fa6124 to 1af10f2 Compare January 15, 2025 21:53
@ebaron ebaron marked this pull request as ready for review January 15, 2025 21:54
@ebaron
Copy link
Member Author

ebaron commented Jan 15, 2025

I've removed the WebClientOptions code since it doesn't seem to work due to Quarkus's setting taking precedence. I think this is all we need on the Cryostat side until we implement #778.

@ebaron ebaron requested a review from a team January 15, 2025 21:57
@ebaron
Copy link
Member Author

ebaron commented Jan 15, 2025

/build_test

Copy link

Workflow started at 1/15/2025, 4:57:36 PM. View Actions Run.

Copy link

No GraphQL schema changes detected.

Copy link

No OpenAPI schema changes detected.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/12797712620

@andrewazores andrewazores merged commit f4e2a5e into cryostatio:main Jan 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Story] Optionally disable hostname verification when connecting to agent
2 participants