feat: introduced support for the s3 proxying #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably should not be merged for now, I am bringing it here to show how we fixed things following our discussion on slack.
To reassume things:
I left current behaviour as it is, and introduced a new config var
use-s3-proxy
, which permits to upload cookbooks directly through /filestore/ endpoint.Initial tests went well, but if this is merged it's going to be a breaking change for users.