Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WEB-9: Active announcements #22

Merged
merged 4 commits into from
Aug 20, 2024
Merged

WEB-9: Active announcements #22

merged 4 commits into from
Aug 20, 2024

Conversation

helenjb
Copy link
Contributor

@helenjb helenjb commented Aug 19, 2024

Overview

Implemented UI for active announcements component.

Changes Made

  • Added CourseGrab.png, Eatery.png, Resell.png, Scooped.png, Transit.png, Uplift.png, and Volume.png to /public/app-icons
  • Implemented active announcement banner UI component in ActiveCell.tsx
  • Implemented active announcements UI component in ActiveAnnouncements.tsx
  • Added AppIcon.tsx and EditIcon.tsx to /components/icons
  • Added functions to utils.ts and appropriate testing in utils.test.ts
  • Added testing in page.tsx

Test Coverage

Tested ActiveAnnouncements.tsx component (and subsequently, ActiveCell.tsx component) in page.tsx by passing in hard-coded data. Tested empty state (caused by either no announcements being passed in or only future announcements being passed in) and filled state (with multiple active and upcoming announcements). In utils.test.ts, tested filterOutPastAnnouncements, dateInRange, and formatDate.

@helenjb helenjb requested a review from vinnie4k August 19, 2024 17:28
@helenjb helenjb force-pushed the WEB-9-active-announcements branch from c3df7b2 to 0d9866d Compare August 19, 2024 18:01
@vinnie4k vinnie4k added this to the MVP Launch milestone Aug 19, 2024
@vinnie4k vinnie4k added the enhancement New feature or request label Aug 19, 2024
@vinnie4k vinnie4k linked an issue Aug 19, 2024 that may be closed by this pull request
WEB-9: Active announcements #19
Closed
vinnie4k
vinnie4k requested changes Aug 19, 2024
View reviewed changes
src/utils/utils.ts Outdated Show resolved Hide resolved
src/utils/utils.ts Outdated Show resolved Hide resolved
src/utils/utils.ts Outdated Show resolved Hide resolved
tests/utils.test.ts Outdated Show resolved Hide resolved
tests/utils.test.ts Outdated Show resolved Hide resolved
src/components/landing/ActiveCell.tsx Outdated Show resolved Hide resolved
src/components/landing/ActiveCell.tsx Outdated Show resolved Hide resolved
src/components/landing/ActiveCell.tsx Outdated Show resolved Hide resolved
src/components/landing/ActiveCell.tsx Outdated Show resolved Hide resolved
src/components/landing/ActiveCell.tsx Outdated Show resolved Hide resolved
@helenjb helenjb requested a review from vinnie4k August 19, 2024 23:56
vinnie4k
vinnie4k requested changes Aug 20, 2024
View reviewed changes
src/components/shared/LiveIndicator.tsx Outdated Show resolved Hide resolved
src/utils/utils.ts Outdated Show resolved Hide resolved
@helenjb helenjb requested a review from vinnie4k August 20, 2024 03:16
vinnie4k
vinnie4k approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@vinnie4k vinnie4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function formatDate may need to be renamed in the future if we plan on doing a separate format, but it's fine for now.

@helenjb helenjb merged commit 139959e into main Aug 20, 2024
1 check passed
@helenjb helenjb deleted the WEB-9-active-announcements branch August 20, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnie4k vinnie4k vinnie4k approved these changes

Assignees

@helenjb helenjb

Labels
enhancement New feature or request
Projects
None yet
Milestone
MVP Launch
Development

Successfully merging this pull request may close these issues.

WEB-9: Active announcements
2 participants
@helenjb @vinnie4k