Begin v3/route by copying v2 into a new v3 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanna-zhou
requested review from
grebneerg,
aliciaxw,
yuna878,
connorreinhold,
raahimenon and
ckdesir
aliciaxw
approved these changes
Oct 11, 2020
| uid, | ||
| } = req.body; | ||
|
|
||
| const isArriveBy = (arriveBy === '1' || arriveBy === true || arriveBy === 'true' || arriveBy === 'True'); |
There was a problem hiding this comment.
why are there so many possible inputs for arriveBy?
There was a problem hiding this comment.
that's a good question :) it's because people send in all types of random stuff to us so this is a precaution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some really redundant/jank things we want to get rid of from v2:
Changes Made
Test Coverage
Works locally, and although it's a minor change I'll be deploying to the server
Next Steps
Related PRs or Issues
#307