Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Re-add bars for professor-side poll results] #356

Merged
merged 9 commits into from
Mar 4, 2020

Conversation

chalo2000
Copy link
Member

@chalo2000 chalo2000 commented Feb 10, 2020

Overview

The professor bars weren't proportional like the student ones, so I added that back.

Professor side is now also redesigned

Changes Made

I moved some things in and out of a switch statement to give the professor the students' proportional bars. There are, however, other issues to resolve before integrating this into the app.

Image 1)
Just re-enabling bars doesn't look very nice; the corner radius on the highlightView bar clashes with the rectangular outer bar of the containerView. The background colors of the behind the bars also make the correct answer bar blend in too much and the light gray bars clash against the darker background.

Image 2)
This is after I fixed the issues from above. It looks nicer now.

Image 3)
The issue with this approach is that without the green background, I cannot tell what was originally the right answer unless at least one person answers it. In this case, it is obvious that the first option is the correct answer since the second option is not green, but what would we do in cases of more than 2 choices to choose from and at least 2 choices with no answers at all?

I feel we need to get some designs to fix this.

Lots of refactoring in MCResultCell to make code more succinct and clearer.

Test Coverage

Manual testing (see images)

Next Steps

After figuring out the proper approach to resolve the new design issue, resolve more Github issues.

A couple of bugs discovered when implementing the new designs, especially for making draft questions (like #363). Will be putting up new issues to record these.

Related PRs or Issues

#344

Screenshots

Old screenshots
1 Just re-enabling bars Before mods
2 Modifying the bars a little After mods
3 Issue with new modification After mods issue
Student gets right answer

ezgif com-resize

Student gets wrong answer

ezgif com-resize (1)

Professor side with 2 devices changing their answers

ezgif com-resize (2)

@chalo2000 chalo2000 marked this pull request as ready for review February 24, 2020 03:52
@chalo2000 chalo2000 requested a review from YKo20010 February 24, 2020 03:52
Copy link
Collaborator

@jackthmp jackthmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! just a couple minor things

Pollo/Views/Cards/MCResultCell.swift Outdated Show resolved Hide resolved
Pollo/Views/Cards/MCResultCell.swift Outdated Show resolved Hide resolved
@jackthmp jackthmp merged commit d2aba9d into master Mar 4, 2020
@jackthmp jackthmp deleted the gonzalo/readd_prof_bars branch March 4, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants