Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul our toolchain #137

Merged
merged 22 commits into from
Jan 3, 2025
Merged

Overhaul our toolchain #137

merged 22 commits into from
Jan 3, 2025

Conversation

lgarron
Copy link
Member

@lgarron lgarron commented Jan 2, 2025

This is a reworking of: #112

  • Replace gulp with a build on fantasticon.
  • Update package exports to match.
  • Generate icons.cubing.net from the built lib.
    • Remove Bootstrap and modernize the docs.
  • Adopt bun for faster building, running uncompiled TypeScript scripts, and keeping dependencies up to date cheaply.

The SVG fonts aren't a 100% pixel-perfect alignment match to what they were before, but I've adjusted things so that they should be very close to a drop-in replacement.

Things that require fixing before merging:

  • Figure out what to do about nix compat with @jfly
  • Include the latest SVGs from main.
  • Fix up SVGs that relied on painting white instead of boolean operations.
  • Update README.md.

Fixes #55 and #93

@lgarron lgarron force-pushed the lgarron/ungulp branch 7 times, most recently from 4de78e6 to 614efb0 Compare January 2, 2025 16:51
@lgarron
Copy link
Member Author

lgarron commented Jan 2, 2025

Here's a screenshot of the updated generated site:
localhost_8000_dist_web_icons cubing net_

Copy link
Member

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I dm-ed you about re-nixifying this. (I'm running into an issue where the lockfile you've committed is missing an integrity hash).

The website redesign looks great, but I do have some feedback. How hard would it be to pull that into a separate PR so we can focus this PR entirely on harmonizing the nix stuff with the bun stuff?

.github/workflows/publish-github-release.yaml Outdated Show resolved Hide resolved
@lgarron
Copy link
Member Author

lgarron commented Jan 3, 2025

The website redesign looks great, but I do have some feedback. How hard would it be to pull that into a separate PR so we can focus this PR entirely on harmonizing the nix stuff with the bun stuff?

Not too hard, but I don't want to touch any old website code and we'd have to coordinate the branches to make sure it stays up to date.

@lgarron
Copy link
Member Author

lgarron commented Jan 3, 2025

The website redesign looks great, but I do have some feedback. How hard would it be to pull that into a separate PR so we can focus this PR entirely on harmonizing the nix stuff with the bun stuff?

Not too hard, but I don't want to touch any old website code and we'd have to coordinate the branches to make sure it stays up to date.

Split into: #138

.gitignore Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jfly and others added 2 commits January 2, 2025 23:11
Co-authored-by: Lucas Garron <[email protected]>
It's coming as the new default in bun 1.2.0.
@lgarron
Copy link
Member Author

lgarron commented Jan 3, 2025

  • Fix up SVGs that relied on painting white instead of boolean operations.

I have this mostly done, but will address it in a followup PR.

@lgarron lgarron merged commit fca76be into main Jan 3, 2025
1 check passed
@lgarron lgarron deleted the lgarron/ungulp branch January 3, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm audit is failing
2 participants