Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty-Print DocStringArgument Step Arguments #2953

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danielmiladinov
Copy link

@danielmiladinov danielmiladinov commented Dec 8, 2024

🤔 What's changed?

The pretty formatter now also prints docstring step arguments, in addition to datatable step arguments

⚡️ What's your motivation?

I use the pretty formatter to print out my test results, and I noticed that everything gets printed except for docstring step arguments. It felt like this was a missing or incomplete feature. Regardless, I want to have my formatted test results include the contents of the step docstrings.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)
  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

I'm not sure what else needs to be done before this pull request can be merged. I don't know if this needs to be announced or if I should update anything in the documentation or changelog. If that's required, please let me know what other changes I should make, and I will make them!

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Cheers.

Please run do mvn install and in doing so spotless will format the code.

And you can add a new entry to the change log under the "fixed" header.

Thanks, @mpkorstanje!

Signed-off-by: Daniel Miladinov <[email protected]>
@danielmiladinov
Copy link
Author

@mpkorstanje Please let me know if there is anything else I need to change before this pull request can be merged.

Wishing you all the best this holiday season and I hope you have a Happy New Year! 🎉 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants