Remove experimental zeroskip database backend #5199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliefm
requested changes
Jan 10, 2025
lib/imapoptions
Outdated
| @@ -217,7 +217,7 @@ are listed with ``<none>''. | |||
| /* Alternative INBOX spellings that can't be accessed in altnamespace | |||
| otherwise go under here. */ | |||
|
|
|||
| { "annotation_db", "twoskip", STRINGLIST("skiplist", "twoskip", "zeroskip"), "3.1.6" } | |||
| { "annotation_db", "twoskip", STRINGLIST("skiplist", "twoskip"), "3.1.6" } | |||
There was a problem hiding this comment.
Need to replace the version number with "UNRELEASED". This applies to all the other foo_db option changes too, except for backup_db which I'll address separately
lib/imapoptions
Outdated
| @@ -549,7 +549,7 @@ Blank lines and lines beginning with ``#'' are ignored. | |||
| { "backup_retention", "7d", DURATION, "3.12.0", "3.12.0" } | |||
| /* Deprecated. No longer used. */ | |||
|
|
|||
| { "backup_db", "twoskip", STRINGLIST("skiplist", "sql", "twoskip", "zeroskip"), "3.12.0", "3.12.0" } | |||
| { "backup_db", "twoskip", STRINGLIST("skiplist", "sql", "twoskip"), "3.12.0", "3.12.0" } | |||
There was a problem hiding this comment.
This case is interesting, because the option is already deprecated (since 3.12.0), but we're changing it again (by necessity I think).
I think perhaps you should change the first version number (which is the last_modified field) to "UNRELEASED", to reflect that it has been modified; but leave the second version number (the deprecated_since field) as "3.12.0", since that was when it was deprecated and that fact hasn't changed.
If that doesn't work, then I guess leave both version numbers as "3.12.0".
It never was ready for production use, is not distributed anymore in cyruslibs and is not developed further.
rsto
force-pushed
the
cyr-1417-remove-zeroskip
branch
from
ed44d60 to
f9d140a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It never was ready for production use, is not distributed anymore in cyruslibs and is not developed further.