Skip to content

Commit

Permalink
No longer build the github action using python 3.8
Browse files Browse the repository at this point in the history
Summary:
This is needed to be able to deploy newer versions of the dagster and dagster-cloud CLI.

Once we do this, we can no longer push to v0.1 or we may break users on python 3.8 / older versions. We need to move this action to a weekly release schedule anyway, so this is the opportunity to do that.
  • Loading branch information
gibsondan committed Jan 15, 2025
1 parent 32181d5 commit 86ef380
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion scripts/release.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def build_dagster_cloud_pex(
platform_args = []

# each of the default versions used by ubuntu 20.04 / 22.04 / 24.04 respectively
for py_version in ["38", "310", "312"]:
for py_version in ["310", "312"]:
platform_args.extend(
[
f"--platform=manylinux2014_x86_64-cp-{py_version}-cp{py_version}",
Expand Down
8 changes: 4 additions & 4 deletions src/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,20 @@ FROM --platform=linux/amd64 quay.io/pypa/manylinux_2_28_x86_64:latest

# Install deps
RUN yum update -y & yum install -y git
RUN /opt/python/cp38-cp38/bin/python -m pip install pex
RUN /opt/python/cp311-cp311/bin/python -m pip install pex

RUN /opt/python/cp38-cp38/bin/python -m pip install dagster-cloud-cli
# RUN /opt/python/cp38-cp38/bin/python -m pip install dagster-cloud-cli
RUN /opt/python/cp39-cp39/bin/python -m pip install dagster-cloud-cli
RUN /opt/python/cp310-cp310/bin/python -m pip install dagster-cloud-cli
RUN /opt/python/cp311-cp311/bin/python -m pip install dagster-cloud-cli
RUN /opt/python/cp312-cp312/bin/python -m pip install dagster-cloud-cli

# Create virtual environment using PEX
COPY generated/gha/dagster-cloud.pex /dagster-cloud.pex
RUN PEX_TOOLS=1 /opt/python/cp38-cp38/bin/python /dagster-cloud.pex venv /venv-dagster-cloud
RUN PEX_TOOLS=1 /opt/python/cp311-cp311/bin/python /dagster-cloud.pex venv /venv-dagster-cloud

# Add all the relevant Python binaries to the PATH
ENV PATH="/venv-dagster-cloud/bin:/opt/python/cp38-cp38/bin:/opt/python/cp39-cp39/bin:/opt/python/cp310-cp310/bin:/opt/python/cp311-cp311/bin:/opt/python/cp312-cp312/bin:$PATH"
ENV PATH="/venv-dagster-cloud/bin:/opt/python/cp39-cp39/bin:/opt/python/cp310-cp310/bin:/opt/python/cp311-cp311/bin:/opt/python/cp312-cp312/bin:$PATH"


# Copy all src scripts
Expand Down

0 comments on commit 86ef380

Please sign in to comment.