Skip to content

Commit

Permalink
fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
shalabhc committed May 18, 2023
1 parent 869bc64 commit 3e8bb66
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/dagster-cloud-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ concurrency:
env:
# The organization name in Dagster Cloud
DAGSTER_CLOUD_ORGANIZATION: "<organization-name>"
# An API token generated in https://dagster.cloud/
# The API token from https://dagster.cloud/ should be stored in Secrets
DAGSTER_CLOUD_API_TOKEN: ${{ secrets.DAGSTER_CLOUD_API_TOKEN }}
# Path to the root folder containing the dagster project
DAGSTER_PROJECT_DIR: "."
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
# # https://github.com/aws-actions/amazon-ecr-login
# - name: Configure AWS credentials
# if: steps.prerun.outputs.result != 'skip'
# uses: aws-actions/configure-aws-credentials@v1
# uses: aws-actions/configure-aws-credentials@v2
# with:
# aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
# aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
Expand Down Expand Up @@ -126,14 +126,14 @@ jobs:
with:
context: .
push: true
tags: ${{ env.IMAGE_REGISTRY }}:${{ env.IMAGE_TAG }}-quickstart-etl
tags: ${{ env.IMAGE_REGISTRY }}:${{ env.IMAGE_TAG }}-quickstart_etl

- name: Update build session with image tag for quickstart_etl
id: ci-set-build-output-example-location
if: steps.prerun.outputs.result != 'skip'
uses: dagster-io/dagster-cloud-action/actions/utils/[email protected]
with:
command: "ci set-build-output --location-name=data-eng-pipeline --image-tag=$IMAGE_TAG-quickstart-etl"
command: "ci set-build-output --location-name=quickstart_etl --image-tag=$IMAGE_TAG-quickstart_etl"

# Deploy all code locations in this build session to Dagster Cloud
- name: Deploy to Dagster Cloud
Expand Down
4 changes: 4 additions & 0 deletions dagster_cloud.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@ locations:
- location_name: quickstart_etl
code_source:
package_name: quickstart_etl
build:
directory: ./
registry: <account-id>.dkr.ecr.us-west-2.amazonaws.com/<image-name>
# registry: ghcr.io/<org>/<image-name>
2 changes: 0 additions & 2 deletions workspace.yaml

This file was deleted.

0 comments on commit 3e8bb66

Please sign in to comment.