-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues/483 and add a basic Node example #484
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for your contribution, it is much appreciated! I've left a few comments
dist/chunks/xmldom-623c1b6b.min.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not push the dist, we will do it during the next release 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 done in f910ea0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh... my bad, I deleted them :P Let me restore the original dist folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap, now the dist folder has no changes. Solved in commit 2b48c61
Example Node: re-use the same information than the root package Co-authored-by: Zac <[email protected]>
Thank you @ZacharieTFR, I made those changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you moved the example folder and added the node, can you update the readme aswell ?
Line 18 in d6420de
To explore a practical example of how the vast client can be implemented, please visit this [link](https://githubbox.com/dailymotion/vast-client-js/tree/master/examples). |
Fix: The EOF was missing Co-authored-by: Zac <[email protected]>
I changed this text in the last commit:
@ZacharieTFR Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Awesome!! just FYI: we are using this library in this project https://github.com/montevideo-tech/vast-2-sgai/ .A basic VAST-2-SGAI (VAST to Asset List and ListMPD) opens-ource microservice :) |
Description
Issue
#483
Type