Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qualpath for imported modules #177

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

growly
Copy link
Collaborator

@growly growly commented Aug 31, 2023

Literally Dan's drive-by fix in #176

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #177 (c69ae53) into main (524373b) will increase coverage by 0.01%.
Report is 11 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   87.20%   87.22%   +0.01%     
==========================================
  Files         109      109              
  Lines        9577     9678     +101     
==========================================
+ Hits         8352     8442      +90     
- Misses       1225     1236      +11     
Files Changed Coverage Δ
hdl21/qualname.py 86.66% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dan-fritchman
Copy link
Owner

Great catch here.
Merging.
I'm gonna leave the generating issue #176 open until we have a test for it.

@dan-fritchman dan-fritchman merged commit 06a1d40 into dan-fritchman:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants