warning: manual implementation of an assign operation --> clicky-core/src/sys/ipod4g/mod.rs:474:25 | 474 | addr = addr | 0x6000_f100; | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `addr |= 0x6000_f100` ... 567 | / mmap! { 568 | | RAM { 569 | | 0x1000_0000..=0x11ff_ffff => sdram, 570 | | 0x4000_0000..=0x4001_7fff => fastram, ... | 628 | | } 629 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: this warning originates in the macro `impl_mem_r` which comes from the expansion of the macro `mmap` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: manual implementation of an assign operation --> clicky-core/src/sys/ipod4g/mod.rs:474:25 | 474 | addr = addr | 0x6000_f100; | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `addr |= 0x6000_f100` ... 567 | / mmap! { 568 | | RAM { 569 | | 0x1000_0000..=0x11ff_ffff => sdram, 570 | | 0x4000_0000..=0x4001_7fff => fastram, ... | 628 | | } 629 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: this warning originates in the macro `impl_mem_r` which comes from the expansion of the macro `mmap` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: manual implementation of an assign operation --> clicky-core/src/sys/ipod4g/mod.rs:474:25 | 474 | addr = addr | 0x6000_f100; | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `addr |= 0x6000_f100` ... 567 | / mmap! { 568 | | RAM { 569 | | 0x1000_0000..=0x11ff_ffff => sdram, 570 | | 0x4000_0000..=0x4001_7fff => fastram, ... | 628 | | } 629 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: `#[warn(clippy::assign_op_pattern)]` on by default = note: this warning originates in the macro `impl_mem_r` which comes from the expansion of the macro `mmap` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: this block may be rewritten with the `?` operator --> clicky-core/src/devices/generic/ide/mod.rs:612:21 | 612 | / if let Err(e) = self.blockdev.seek(io::SeekFrom::Start(offset * 512)).await { 613 | | // XXX: actually set error bits 614 | | return Err(e); 615 | | } | |_____________________^ help: replace it with: `self.blockdev.seek(io::SeekFrom::Start(offset * 512)).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark

warning: this block may be rewritten with the `?` operator --> clicky-core/src/devices/generic/ide/mod.rs:531:21 | 531 | / if let Err(e) = self.blockdev.read_exact(self.iobuf.as_raw()).await { 532 | | // XXX: actually set error bits 533 | | return Err(e); 534 | | } | |_____________________^ help: replace it with: `self.blockdev.read_exact(self.iobuf.as_raw()).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark

warning: this block may be rewritten with the `?` operator --> clicky-core/src/devices/generic/ide/mod.rs:523:21 | 523 | / if let Err(e) = self.blockdev.seek(io::SeekFrom::Start(offset * 512)).await { 524 | | // XXX: actually set error bits 525 | | return Err(e); 526 | | } | |_____________________^ help: replace it with: `self.blockdev.seek(io::SeekFrom::Start(offset * 512)).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark

warning: this block may be rewritten with the `?` operator --> clicky-core/src/devices/generic/ide/mod.rs:388:17 | 388 | / if let Err(e) = self.blockdev.write_all(self.iobuf.as_raw()).await { 389 | | // XXX: actually set error bits 390 | | return Err(e); 391 | | } | |_________________^ help: replace it with: `self.blockdev.write_all(self.iobuf.as_raw()).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark

warning: this block may be rewritten with the `?` operator --> clicky-core/src/devices/generic/ide/mod.rs:336:21 | 336 | / if let Err(e) = self.blockdev.read_exact(self.iobuf.as_raw()).await { 337 | | // XXX: actually set error bits 338 | | return Err(e); 339 | | } | |_____________________^ help: replace it with: `self.blockdev.read_exact(self.iobuf.as_raw()).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark = note: `#[warn(clippy::question_mark)]` on by default

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> clicky-core/src/devices/generic/ide/mod.rs:291:13 | 291 | ((cyl * NUM_HEADS as u64 + head) * NUM_SECTORS as u64 + sector) as u64 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((cyl * NUM_HEADS as u64 + head) * NUM_SECTORS as u64 + sector)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: fields `id`, `checksum`, `vers`, and `load_addr` are never read --> clicky-core/src/sys/ipod4g/hle_bootloader/firmware.rs:77:9 | 74 | pub struct ImageInfo { | --------- fields in this struct ... 77 | pub id: u32, | ^^ ... 82 | pub checksum: u32, | ^^^^^^^^ 83 | pub vers: u32, | ^^^^ 84 | pub load_addr: u32, | ^^^^^^^^^ | = note: `ImageInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

warning: field `ext_header_loc` is never read --> clicky-core/src/sys/ipod4g/hle_bootloader/firmware.rs:50:9 | 47 | pub struct VolumeHeader { | ------------ field in this struct ... 50 | pub ext_header_loc: u16, | ^^^^^^^^^^^^^^ | = note: `VolumeHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

warning: field `header` is never read --> clicky-core/src/sys/ipod4g/hle_bootloader/firmware.rs:12:9 | 11 | pub struct FirmwareMeta { | ------------ field in this struct 12 | pub header: VolumeHeader, | ^^^^^^ | = note: `FirmwareMeta` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

warning: field `0` is never read --> clicky-core/src/devices/generic/ide/mod.rs:169:18 | 169 | DMAMultiWord(u8), | ------------ ^^ | | | field in this variant | = note: `IdeTransferMode` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 169 | DMAMultiWord(()), | ~~

warning: field `0` is never read --> clicky-core/src/devices/generic/ide/mod.rs:168:19 | 168 | DMASingleWord(u8), | ------------- ^^ | | | field in this variant | = note: `IdeTransferMode` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 168 | DMASingleWord(()), | ~~

warning: field `0` is never read --> clicky-core/src/devices/generic/ide/mod.rs:167:20 | 167 | PioFlowControl(u8), | -------------- ^^ | | | field in this variant | = note: `IdeTransferMode` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 167 | PioFlowControl(()), | ~~

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/