Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add lldb-specific HostIoOpenFlags #100

Merged
merged 3 commits into from
Feb 22, 2022
Merged

add lldb-specific HostIoOpenFlags #100

merged 3 commits into from
Feb 22, 2022

Conversation

mrk-its
Copy link
Contributor

@mrk-its mrk-its commented Feb 21, 2022 •
edited by daniel5151
Loading

Description

This PR adds lldb-specific HostIoOpenFlags, as proposed in #99

API Stability

  • This PR does not require a breaking API change

Checklist

  • Implementation
    • cargo build compiles without errors or warnings
    • cargo clippy runs without errors or warnings
    • cargo fmt was run
    • All tests pass
  • Documentation
    • rustdoc + approprate inline code comments
    • Updated CHANGELOG.md

@mrk-its
Copy link
Contributor Author

mrk-its commented Feb 21, 2022

second try :)

daniel5151
daniel5151 reviewed Feb 22, 2022
View reviewed changes
src/target/ext/host_io.rs Outdated Show resolved Hide resolved
src/target/ext/host_io.rs Outdated Show resolved Hide resolved
daniel5151
daniel5151 approved these changes Feb 22, 2022
View reviewed changes
Copy link
Owner

@daniel5151 daniel5151 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks for the PR 😄

I'll push 0.6.1 up to crates.io after work today

@daniel5151 daniel5151 merged commit c2d64fa into daniel5151:master Feb 22, 2022
@daniel5151 daniel5151 mentioned this pull request Feb 22, 2022
Open
@daniel5151
Copy link
Owner

0.6.1 is published to crates.io

@daniel5151 daniel5151 mentioned this pull request Jun 5, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel5151 daniel5151 daniel5151 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrk-its @daniel5151