Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bitwise instead of logical warning #2746

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/notcurses/notcurses.h
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ ncchannel_set_palindex(uint32_t* channel, unsigned idx){
static inline bool
ncchannel_rgb_p(uint32_t channel){
// bitwise or is intentional (allows compiler more freedom)
return !(ncchannel_default_p(channel) | ncchannel_palindex_p(channel));
return !(ncchannel_default_p(channel) || ncchannel_palindex_p(channel));
}

// Extract the 8-bit red component from a 32-bit channel. Only valid if
Expand Down
Loading