Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-10028 client: Add Go bindings for libdaos (Pool) #15659

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mjmac
Copy link
Contributor

@mjmac mjmac commented Dec 22, 2024

Start the work of converting the raw cgo in the daos
tool into proper Go bindings for libdaos. This patch
covers pool functionality and adds some new infrastructure
common to both pools and containers.

Features: daos_cmd pool
Required-githooks: true
Signed-off-by: Michael MacDonald [email protected]

Copy link

Ticket title is 'Update golang binding for the DAOS API'
Status is 'In Progress'
Labels: 'SODACODE2022'
https://daosio.atlassian.net/browse/DAOS-10028

@mjmac mjmac force-pushed the mjmac/DAOS-10028-pool branch from 20e923c to 68a15e1 Compare December 22, 2024 01:09
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15659/2/execution/node/345/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15659/2/execution/node/346/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15659/2/execution/node/337/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15659/2/execution/node/340/log

@daosbuild1
Copy link
Collaborator

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15659/2/execution/node/508/log

@mjmac mjmac force-pushed the mjmac/DAOS-10028-pool branch 2 times, most recently from 785f5c7 to d94cc38 Compare December 22, 2024 16:02
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15659/4/execution/node/1483/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15659/5/execution/node/544/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15659/5/execution/node/560/log

@mjmac mjmac force-pushed the mjmac/DAOS-10028-pool branch 2 times, most recently from 5a76de4 to 628f3ce Compare December 28, 2024 00:03
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15659/7/testReport/

@mjmac mjmac force-pushed the mjmac/DAOS-10028-pool branch 2 times, most recently from 510d64b to 90ef6d7 Compare December 28, 2024 18:58
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15659/9/execution/node/1405/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15659/9/execution/node/1415/log

@mjmac mjmac force-pushed the mjmac/DAOS-10028-pool branch from 90ef6d7 to ad55ebd Compare December 31, 2024 12:32
@mjmac mjmac force-pushed the mjmac/DAOS-10028-pool branch 7 times, most recently from 6d9b688 to 5f28018 Compare January 13, 2025 23:04
@mjmac mjmac force-pushed the mjmac/DAOS-10028-pool branch 2 times, most recently from 7a1ccde to aae584f Compare January 17, 2025 21:24
@mjmac mjmac force-pushed the mjmac/DAOS-10028-pool branch from aae584f to cf8ef8a Compare January 17, 2025 22:59
Start the work of converting the raw cgo in the daos
tool into proper Go bindings for libdaos. This patch
covers pool functionality and adds some new infrastructure
common to both pools and containers.

Features: daos_cmd
Required-githooks: true
Signed-off-by: Michael MacDonald <[email protected]>
@mjmac mjmac force-pushed the mjmac/DAOS-10028-pool branch from cf8ef8a to 9b0d824 Compare January 17, 2025 23:01
@mjmac mjmac marked this pull request as ready for review January 18, 2025 16:36
@mjmac mjmac requested review from a team as code owners January 18, 2025 16:36
@mjmac mjmac self-assigned this Jan 18, 2025
@mjmac
Copy link
Contributor Author

mjmac commented Jan 18, 2025

Note to reviewers... Yeah, this is big. It's the first of several patches, though, and contains a lot of the infrastructure needed to start the change over to using the client API instead of raw cgo in the daos tool. There is no new functionality here, and my focus will be on maintaining parity with the existing implementation for now. Most of the "new" code is just the existing cgo moved over into the API, along with extensive unit tests. Imagine that, unit tests!

For context, this is the first follow-on PR (still a WIP): #15721

Features: daos_cmd
Required-githooks: true
Signed-off-by: Michael MacDonald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants