Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16973 cq: fix codespell warnings #15764

Merged
merged 1 commit into from
Jan 22, 2025
Merged

DAOS-16973 cq: fix codespell warnings #15764

merged 1 commit into from
Jan 22, 2025

Conversation

daltonbohning
Copy link
Contributor

Doc-only: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning
DAOS-16973 cq: fix codespell warnings
3549928 
Doc-only: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning self-assigned this Jan 22, 2025
@github-actions GitHub Actions
Copy link

Ticket title is 'fix new codespell warnings'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16973

@daltonbohning daltonbohning marked this pull request as ready for review January 22, 2025 16:20
@daltonbohning daltonbohning requested review from a team as code owners January 22, 2025 16:20
grom72
grom72 approved these changes Jan 22, 2025 •
edited
Loading
View reviewed changes
@daltonbohning daltonbohning requested a review from a team January 22, 2025 16:51
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 22, 2025
@daltonbohning
Copy link
Contributor Author

GHA linting and builds passed. Skipped other testing since this only modifies comments

@daltonbohning daltonbohning merged commit 314ad1c into master Jan 22, 2025
39 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16973 branch January 22, 2025 16:51
daltonbohning added a commit that referenced this pull request Jan 22, 2025
@daltonbohning
DAOS-16973 cq: fix codespell warnings (#15764)
309d3f9 
Doc-only: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Jan 22, 2025
@daltonbohning
DAOS-16973 cq: fix codespell warnings (#15764) (#15765)
b4a5117 
Signed-off-by: Dalton Bohning <[email protected]>
@mjmac mjmac mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@grom72 grom72 grom72 approved these changes

@janekmi janekmi Awaiting requested review from janekmi

@ryon-jensen ryon-jensen Awaiting requested review from ryon-jensen

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daltonbohning @grom72 @phender