Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16973 cq: fix codespell warnings (#15764) #15765

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

daltonbohning
Copy link
Contributor

Doc-only: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Doc-only: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jan 22, 2025
@daltonbohning daltonbohning self-assigned this Jan 22, 2025
Copy link

Ticket title is 'fix new codespell warnings'
Status is 'Awaiting backport'
Labels: 'request_for_2.6.3'
https://daosio.atlassian.net/browse/DAOS-16973

@daltonbohning daltonbohning marked this pull request as ready for review January 22, 2025 16:55
@daltonbohning daltonbohning requested review from a team as code owners January 22, 2025 16:55
Doc-only: true

Signed-off-by: Dalton Bohning <[email protected]>
@@ -1,5 +1,6 @@
//
// (C) Copyright 2020-2024 Intel Corporation.
// (C) Copyright 2025 Hewlett Packard Enterprise Development LP
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is unclean

@daltonbohning daltonbohning added unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. and removed clean-cherry-pick Cherry-pick from another branch that did not require additional edits labels Jan 22, 2025
@daltonbohning daltonbohning requested a review from a team January 22, 2025 22:28
@daltonbohning daltonbohning added forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. approved-to-merge PR has received release branch merge approval labels Jan 22, 2025
@daltonbohning daltonbohning merged commit b4a5117 into release/2.6 Jan 22, 2025
39 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16973-2.6 branch January 22, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-to-merge PR has received release branch merge approval forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Development

Successfully merging this pull request may close these issues.

3 participants