Skip to content

Commit

Permalink
mem: resolving conflicts
Browse files Browse the repository at this point in the history
This change resolves all the conflits encountered while rebasing.

Signed-off-by: Kaustav Goswami <[email protected]>
  • Loading branch information
kaustav-goswami committed Nov 22, 2023
1 parent 82f57d2 commit 3ad98d8
Show file tree
Hide file tree
Showing 11 changed files with 3 additions and 896 deletions.
47 changes: 0 additions & 47 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,6 @@ about: Create a report to help us find and fix the bug
title: ''
labels: bug
assignees: ''
<<<<<<< HEAD
<<<<<<< HEAD
=======

>>>>>>> misc: Add ".github" changes to minor release
=======
>>>>>>> misc: Copy .github directory from develop to stable (#458)
---

**Describe the bug**
Expand All @@ -24,8 +17,6 @@ If you have modified gem5 in some way please state, to the best of your ability,

**To Reproduce**
Steps to reproduce the behavior. Please assume starting from a clean repository:
<<<<<<< HEAD
<<<<<<< HEAD

1. Compile gem5 with command ...
2. Execute the simulation with...
Expand All @@ -38,54 +29,16 @@ int x=2
int y=3
print(x+y)
```
=======
=======

>>>>>>> misc: Copy .github directory from develop to stable (#458)
1. Compile gem5 with command ...
2. Execute the simulation with...

If writing code, or a terminal command, use code blocks. Either an inline code block, `scons build/ALL/gem5.opt` (enclosed in two '`') or a multi-line codeblock:


<<<<<<< HEAD
int y=3'

print(x+y);

\`\`\`
>>>>>>> misc: Add ".github" changes to minor release
=======
```python
int x=2
int y=3
print(x+y)
```
>>>>>>> misc: Copy .github directory from develop to stable (#458)

If possible, please include the Python configuration script used and state clearly any parameters passed.

**Terminal Output**
If applicable, add the terminal output here. If long, only include the relevant lines.
Please put the terminal output in code blocks. I.e.:

<<<<<<< HEAD
<<<<<<< HEAD
```shell
#Terminal output here#
```
=======
\`\`\`

#Terminal output here#

\`\`\`
>>>>>>> misc: Add ".github" changes to minor release
=======
```shell
#Terminal output here#
```
>>>>>>> misc: Copy .github directory from develop to stable (#458)

**Expected behavior**
A clear and concise description of what you expected to happen.
Expand Down
121 changes: 0 additions & 121 deletions .github/workflows/ci-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,32 +14,14 @@ concurrency:
jobs:
pre-commit:
# runs on github hosted runner
<<<<<<< HEAD
<<<<<<< HEAD
=======
>>>>>>> misc: Copy .github directory from develop to stable (#458)
runs-on: ubuntu-22.04
if: github.event.pull_request.draft == false
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v3
- uses: pre-commit/[email protected]
<<<<<<< HEAD
=======
runs-on: ubuntu-22.04
if: github.event.pull_request.draft == false
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v3
- uses: pre-commit/[email protected]
>>>>>>> misc: Copy .github directory from develop to stable

# ensures we have a change-id in every commit, needed for gerrit
<<<<<<< HEAD
=======

# ensures we have a change-id in every commit, needed for gerrit
>>>>>>> misc: Copy .github directory from develop to stable (#458)
check-for-change-id:
# runs on github hosted runner
runs-on: ubuntu-22.04
Expand Down Expand Up @@ -107,7 +89,6 @@ jobs:
build-matrix: ${{ steps.build-matrix.outputs.build-matrix }}
test-dirs-matrix: ${{ steps.dir-matrix.outputs.test-dirs-matrix }}

<<<<<<< HEAD
clang-fast-compilation:
# gem5 binaries built in `quick-gem5-builds` always use GCC.
# Clang is more strict than GCC. This job checks that gem5 compiles
Expand All @@ -124,8 +105,6 @@ jobs:
working-directory: ${{ github.workspace }}
run: scons build/ALL/gem5.fast -j $(nproc)

=======
>>>>>>> misc: Copy .github directory from develop to stable (#458)
testlib-quick-gem5-builds:
runs-on: [self-hosted, linux, x64]
if: github.event.pull_request.draft == false
Expand Down Expand Up @@ -214,103 +193,3 @@ jobs:
needs: testlib-quick-execution
steps:
- run: echo "This job's status is ${{ job.status }}."
<<<<<<< HEAD
=======
check-for-change-id:
# runs on github hosted runner
runs-on: ubuntu-22.04
if: github.event.pull_request.draft == false
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Check for Change-Id
run: |
# loop through all the commits in the pull request
for commit in $(git rev-list ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }}); do
git checkout $commit
if (git log -1 --pretty=format:"%B" | grep -q "Change-Id: ")
then
# passes as long as at least one change-id exists in the pull request
exit 0
fi
done
# if we reach this part, none of the commits had a change-id
echo "None of the commits in this pull request contains a Change-ID, which we require for any changes made to gem5. "\
"To automatically insert one, run the following:\n f=`git rev-parse --git-dir`/hooks/commit-msg ; mkdir -p $(dirname $f) ; "\
"curl -Lo $f https://gerrit-review.googlesource.com/tools/hooks/commit-msg ; chmod +x $f\n Then amend the commit with git commit --amend --no-edit, and update your pull request."
exit 1
build-gem5:
runs-on: [self-hosted, linux, x64, build]
if: github.event.pull_request.draft == false
container: gcr.io/gem5-test/ubuntu-22.04_all-dependencies:latest
needs: [pre-commit, check-for-change-id] # only runs if pre-commit and change-id passes
outputs:
artifactname: ${{ steps.name.outputs.test }}
steps:
- uses: actions/checkout@v3
- id: name
run: echo "test=$(date +"%Y-%m-%d_%H.%M.%S")-artifact" >> $GITHUB_OUTPUT

- name: Build gem5
run: |
scons build/ALL/gem5.opt -j $(nproc)
- uses: actions/upload-artifact@v3
with:
name: ${{ steps.name.outputs.test }}
path: build/ALL/gem5.opt
- run: echo "This job's status is ${{ job.status }}."

unittests-all-opt:
runs-on: [self-hosted, linux, x64, run]
if: github.event.pull_request.draft == false
container: gcr.io/gem5-test/ubuntu-22.04_all-dependencies:latest
needs: [pre-commit, check-for-change-id] # only runs if pre-commit and change-id passes
timeout-minutes: 60
steps:
- uses: actions/checkout@v3
- name: CI Unittests
working-directory: ${{ github.workspace }}
run: scons build/ALL/unittests.opt -j $(nproc)
- run: echo "This job's status is ${{ job.status }}."

testlib-quick:
runs-on: [self-hosted, linux, x64, run]
if: github.event.pull_request.draft == false
container: gcr.io/gem5-test/ubuntu-22.04_all-dependencies:latest
needs: [pre-commit, build-gem5, check-for-change-id]
timeout-minutes: 360 # 6 hours
steps:
- name: Clean runner
run:
rm -rf ./* || true
rm -rf ./.??* || true
rm -rf ~/.cache || true
- uses: actions/checkout@v3
- uses: actions/download-artifact@v3
with:
name: ${{needs.build-gem5.outputs.artifactname}}
path: build/ALL
- run: chmod u+x build/ALL/gem5.opt
- name: The TestLib CI Tests
working-directory: ${{ github.workspace }}/tests
run: ./main.py run --skip-build -vv
- name: create zip of results
if: success() || failure()
run: |
apt-get -y install zip
zip -r output.zip tests/testing-results
- name: upload zip
if: success() || failure()
uses: actions/upload-artifact@v3
env:
MY_STEP_VAR: ${{github.job}}_COMMIT.${{github.sha}}_RUN.${{github.run_id}}_ATTEMPT.${{github.run_attempt}}
with:
name: ${{ env.MY_STEP_VAR }}
path: output.zip
retention-days: 7
- run: echo "This job's status is ${{ job.status }}."
>>>>>>> misc: Add ".github" changes to minor release
=======
>>>>>>> misc: Copy .github directory from develop to stable (#458)
95 changes: 0 additions & 95 deletions .github/workflows/compiler-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,81 +12,28 @@ on:

jobs:
# replication of compiler-tests.sh
<<<<<<< HEAD
<<<<<<< HEAD
=======
>>>>>>> misc: Copy .github directory from develop to stable (#458)
all-compilers:
strategy:
fail-fast: false
matrix:
<<<<<<< HEAD
image: [gcc-version-12, gcc-version-11, gcc-version-10, gcc-version-8, clang-version-16, clang-version-15, clang-version-14, clang-version-13,
clang-version-12, clang-version-11, clang-version-10, clang-version-9, clang-version-8, clang-version-7, ubuntu-20.04_all-dependencies,
=======
image: [gcc-version-12, gcc-version-11, gcc-version-10, gcc-version-9, gcc-version-8, clang-version-16, clang-version-15, clang-version-14,
clang-version-13, clang-version-12, clang-version-11, clang-version-10, clang-version-9, clang-version-8, clang-version-7, ubuntu-20.04_all-dependencies,
>>>>>>> misc: Copy .github directory from develop to stable (#458)
ubuntu-22.04_all-dependencies, ubuntu-22.04_min-dependencies]
opts: [.opt, .fast]
runs-on: [self-hosted, linux, x64]
timeout-minutes: 2880 # 48 hours
<<<<<<< HEAD
<<<<<<< HEAD
container: ghcr.io/gem5/${{ matrix.image }}:latest
steps:
- uses: actions/checkout@v3
with:
=======
all-compilers:
strategy:
fail-fast: false
matrix:
image: [gcc-version-12, gcc-version-11, gcc-version-10, gcc-version-9, gcc-version-8, clang-version-14, clang-version-13, clang-version-12, clang-version-11, clang-version-10, clang-version-9, clang-version-8, clang-version-7, ubuntu-20.04_all-dependencies, ubuntu-22.04_all-dependencies, ubuntu-22.04_min-dependencies]
opts: [.opt, .fast]
<<<<<<< HEAD
runs-on: [self-hosted, linux, x64, run]
=======
runs-on: [self-hosted, linux, x64, build]
>>>>>>> misc: Copy .github directory from develop to stable
timeout-minutes: 2880 # 48 hours
container: gcr.io/gem5-test/${{ matrix.image }}:latest
steps:
- uses: actions/checkout@v3
with:
>>>>>>> misc: Add ".github" changes to minor release
# Scheduled workflows run on the default branch by default. We
# therefore need to explicitly checkout the develop branch.
<<<<<<< HEAD
=======
container: gcr.io/gem5-test/${{ matrix.image }}:latest
=======
container: ghcr.io/gem5/${{ matrix.image }}:latest
>>>>>>> misc: Copy .github directory from develop to stable (#485)
steps:
- uses: actions/checkout@v3
with:
# Scheduled workflows run on the default branch by default. We
# therefore need to explicitly checkout the develop branch.
>>>>>>> misc: Copy .github directory from develop to stable (#458)
ref: develop
- name: Compile build/ALL/gem5${{ matrix.opts }} with ${{ matrix.image }}
run: /usr/bin/env python3 /usr/bin/scons --ignore-style build/ALL/gem5${{ matrix.opts }} -j$(nproc)
timeout-minutes: 600 # 10 hours
<<<<<<< HEAD
=======
ref: develop
- name: Compile build/ALL/gem5${{ matrix.opts }} with ${{ matrix.image }}
run: /usr/bin/env python3 /usr/bin/scons --ignore-style build/ALL/gem5${{ matrix.opts }} -j$(nproc)
timeout-minutes: 600 # 10 hours
>>>>>>> misc: Copy .github directory from develop to stable

# Tests the two latest gcc and clang supported compilers against all gem5 compilations.
<<<<<<< HEAD
=======

# Tests the two latest gcc and clang supported compilers against all gem5 compilations.
>>>>>>> misc: Copy .github directory from develop to stable (#458)
latest-compilers-all-gem5-builds:
strategy:
fail-fast: false
Expand All @@ -98,45 +45,12 @@ jobs:
opts: [.opt]
runs-on: [self-hosted, linux, x64]
timeout-minutes: 2880 # 48 hours
<<<<<<< HEAD
<<<<<<< HEAD
container: ghcr.io/gem5/${{ matrix.image }}:latest
steps:
- uses: actions/checkout@v3
with:
=======
latest-compilers-all-gem5-builds:
strategy:
fail-fast: false
matrix:
gem5-compilation: [ARM, ARM_MESI_Three_Level, ARM_MESI_Three_Level_HTM, ARM_MOESI_hammer, Garnet_standalone, GCN3_X86, MIPS, 'NULL', NULL_MESI_Two_Level, NULL_MOESI_CMP_directory, NULL_MOESI_CMP_token, NULL_MOESI_hammer, POWER, RISCV, SPARC, X86, X86_MI_example, X86_MOESI_AMD_Base, VEGA_X86, GCN3_X86]
image: [gcc-version-12, clang-version-14]
opts: [.opt]
<<<<<<< HEAD
runs-on: [self-hosted, linux, x64, run]
=======
runs-on: [self-hosted, linux, x64, build]
>>>>>>> misc: Copy .github directory from develop to stable
timeout-minutes: 2880 # 48 hours
container: gcr.io/gem5-test/${{ matrix.image }}:latest
steps:
- uses: actions/checkout@v3
with:
>>>>>>> misc: Add ".github" changes to minor release
# Scheduled workflows run on the default branch by default. We
# therefore need to explicitly checkout the develop branch.
<<<<<<< HEAD
=======
container: gcr.io/gem5-test/${{ matrix.image }}:latest
=======
container: ghcr.io/gem5/${{ matrix.image }}:latest
>>>>>>> misc: Copy .github directory from develop to stable (#485)
steps:
- uses: actions/checkout@v3
with:
# Scheduled workflows run on the default branch by default. We
# therefore need to explicitly checkout the develop branch.
>>>>>>> misc: Copy .github directory from develop to stable (#458)
ref: develop
- name: Compile build/${{ matrix.gem5-compilation }}/gem5${{ matrix.opts }} with ${{ matrix.image }}
run: /usr/bin/env python3 /usr/bin/scons --ignore-style build/${{ matrix.gem5-compilation }}/gem5${{ matrix.opts }} -j$(nproc)
Expand All @@ -154,12 +68,3 @@ jobs:
- all-compilers
steps:
- run: echo "This compiler tests have passed."
<<<<<<< HEAD
=======
ref: develop
- name: Compile build/${{ matrix.gem5-compilation }}/gem5${{ matrix.opts }} with ${{ matrix.image }}
run: /usr/bin/env python3 /usr/bin/scons --ignore-style build/${{ matrix.gem5-compilation }}/gem5${{ matrix.opts }} -j$(nproc)
timeout-minutes: 600 # 10 hours
>>>>>>> misc: Copy .github directory from develop to stable
=======
>>>>>>> misc: Copy .github directory from develop to stable (#458)
Loading

0 comments on commit 3ad98d8

Please sign in to comment.