[WIP] feat: Add DateTimeSecondsSinceEpoch
#59975
Conversation
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/405740 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
| /// Creates a [DateTime] instance from seconds since epoch. | ||
| static DateTime fromSecondsSinceEpoch(int seconds) { | ||
| return DateTime.fromMillisecondsSinceEpoch(seconds * 1000); | ||
| } |
There was a problem hiding this comment.
Do note that static methods cannot be added to classes using extension methods. So what you do here is just declaring a static method on the extension itself and which needs to be called with: DateTimeSecondsSinceEpoch.fromSecondsSinceEpoch which I don't think was your intention.
Working-in-progress
Resolve : #59961
Contribution guidelines:
dart format.Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.