Fix broken links (#152) #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jacobtomlinson
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
These all look like good changes to me. Thanks @pratyakshajha.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken links listed in issue #152. I used pytest-check-links to automatically find broken links and fixed them as well.
This is a draft PR, I will need some advice on automatically checking for any broken links. Should there be a step on the CI to fail if there are any failing links? It can be configured to ignore links by patterns.
To test this:
pip install pytest-check-linkspytest --check-links --check-links-ignore ".*/proxy/8787.*" --links-ext "ipynb"