-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to read bw files and return maximum value across an interval #67
base: dev
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returning an error instead of panicing would be helpful otherwise this looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
I'll add python bindings and push here in a second |
…ax_bw' into dev_add_returning_max_bw
@donaldcampbelljr I got the bindings in! Usage, then a couple notes: import gtars
coverage = gtars.utils.read_big_wig_to_coverage("tests/data/test_all_core.bw")
val = coverage.stats("chr1", 0, 29, stat_type="max")
assert val == 4.0 # True I have two notes on this:
|
This PR is probably no longer necessary since the bigtools python bindings may be sufficient. We can close this once confirmed. |
I agree, we can close this |
BigWigRead::open_file(bigwigpath)?