update ci & fix clippy

.github/workflows/ci.yml

@@ -5,7 +5,7 @@ on:
   schedule: [cron: "0 */24 * * *"]
 
 env:
-  CI_RUST_TOOLCHAIN: 1.61.0
+  CI_RUST_TOOLCHAIN: 1.63.0
 
 jobs:
   soft-roce-env:

examples/cm_client.rs

@@ -30,7 +30,7 @@ async fn run(node: &str, service: &str) {
         .alloc_local_mr(Layout::new::<[u8; BUF_SIZE]>())
         .unwrap();
     let _ = lmr.as_mut_slice().write(&[BUF_FILLER; BUF_SIZE]).unwrap();
-    let _ = rdma.send_raw(&lmr).await.unwrap();
+    rdma.send_raw(&lmr).await.unwrap();
     println!("send {:?}", *lmr.as_slice());
 
     // recv raw data from server

src/agent.rs

@@ -337,21 +337,17 @@ impl AgentThread {
 
     /// The main agent function that handles messages sent from the other side
     async fn main(self: Arc<Self>) -> io::Result<()> {
-        // SAFETY: ?
-        // TODO: check safety
         let mut header_buf = self
             .inner
             .allocator
-            // alignment 1 is always correct
+            // SAFETY: alignment 1 is always correct
             .alloc_zeroed_default(unsafe {
                 &Layout::from_size_align_unchecked(*REQUEST_HEADER_MAX_LEN, 1)
             })?;
-        // SAFETY: ?
-        // TODO: check safety
         let mut data_buf = self
             .inner
             .allocator
-            // alignment 1 is always correct
+            // SAFETY: alignment 1 is always correct
             .alloc_zeroed_default(unsafe {
                 &Layout::from_size_align_unchecked(self.max_sr_data_len, 1)
             })?;

src/lib.rs

@@ -96,7 +96,7 @@
     warnings, // treat all wanings as errors
 
     clippy::all,
-    clippy::restriction,
+    // clippy::restriction,
     clippy::pedantic,
     // clippy::nursery, // It's still under development
     clippy::cargo,

src/memory_region/local.rs

@@ -60,7 +60,7 @@ pub unsafe trait LocalMrReadAccess: MrAccess {
     #[inline]
     #[allow(clippy::as_conversions)]
     fn as_ptr_unchecked(&self) -> *const u8 {
-        self.addr() as _
+        self.addr() as *const u8
     }
 
     /// Get the memory region as slice until it is readable
@@ -274,7 +274,7 @@ pub unsafe trait LocalMrWriteAccess: MrAccess + LocalMrReadAccess {
     #[allow(clippy::as_conversions)]
     fn as_mut_ptr_unchecked(&mut self) -> *mut u8 {
         // const pointer to mut pointer is safe
-        self.as_ptr_unchecked() as _
+        self.as_ptr_unchecked() as *mut u8
     }
 
     /// Get the memory region as mutable slice until it is writeable
@@ -556,13 +556,13 @@ impl Drop for LocalMrInner {
         match self.strategy {
             crate::MRManageStrategy::Jemalloc => {
                 // SAFETY: ffi
-                unsafe { tikv_jemalloc_sys::free(self.addr as _) }
+                unsafe { tikv_jemalloc_sys::free(self.addr as *mut libc::c_void) }
             }
             crate::MRManageStrategy::Raw => {
                 // SAFETY: The ptr is allocated via this allocator, and the layout is the same layout
                 // that was used to allocate that block of memory.
                 unsafe {
-                    dealloc(self.addr as _, self.layout);
+                    dealloc(self.addr as *mut u8, self.layout);
                 }
             }
         }

src/mr_allocator.rs

@@ -620,7 +620,7 @@ fn remove_item(addr: *mut c_void) {
 #[allow(clippy::as_conversions)]
 #[allow(clippy::unreachable)]
 fn remove_item_after_lock(map: &mut MutexGuard<BTreeMap<usize, Item>>, addr: *mut c_void) {
-    map.remove(&(addr as _)).map_or_else(
+    map.remove(&(addr as usize)).map_or_else(
         || {
             unreachable!(
                 "can not get item from EXTENT_TOKEN_MAP. addr : {}",

src/work_request.rs

@@ -145,7 +145,7 @@ impl AsRef<ibv_send_wr> for SendWr {
     }
 }
 
-impl<'lm> AsMut<ibv_send_wr> for SendWr {
+impl AsMut<ibv_send_wr> for SendWr {
     fn as_mut(&mut self) -> &mut ibv_send_wr {
         &mut self.inner
     }