fix: light theme flickering (#152)

daytonaio · Sep 16, 2024 · a5a2635 · a5a2635
1 parent 5ab98b6
commit a5a2635
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/src/components/ThemeSelect.astro b/src/components/ThemeSelect.astro
@@ -58,15 +58,6 @@ import lightThemeIcon from '@assets/icons/light-sun.svg?raw'
     /** Update select menu UI, document theme, and local storage state. */
     #onThemeChange(theme: Theme): void {
       ThemeProvider.updatePickers(theme)
-      const themeFinal =
-        theme === 'auto' ? this.#getPreferredColorScheme() : theme
-      if (themeFinal === 'light') {
-        document.body.classList.add('light')
-        document.body.classList.remove('dark')
-      } else {
-        document.body.classList.add('dark')
-        document.body.classList.remove('light')
-      }
       document.documentElement.dataset.theme =
         theme === 'auto' ? this.#getPreferredColorScheme() : theme
       this.#storeTheme(theme)

diff --git a/src/styles/_color.scss b/src/styles/_color.scss
@@ -28,7 +28,7 @@ body {
 
 }
 
-body.light {
+html[data-theme="light"] body {
   --bg-color: #fff;
   --border-color: #dedede;
   --border-extra: #dedede;