fix: flaky e2e test in vue-showcase for webkit #3638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfranzke
reviewed
Jan 3, 2025
mfranzke
previously approved these changes
Jan 3, 2025
Co-authored-by: Maximilian Franzke <[email protected]>
mfranzke
previously approved these changes
Jan 3, 2025
|
🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-vue-tabs-flaky-e2e-test |
mfranzke
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
50% of the pipeline step to gererate vue(webkit) screenshots for tabs fails. There might be some unkown issue maybe caused by the combination of playwrights webkit browser and vue
Types of changes
Further comments