-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry query jobs and use info-level logging for job link, etc #768
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @tbog357 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Thanks for raising the PR!
I've implemented most of it in #630.
Yet you're adding few things in this one that could be making it more worthwhile:
- retries on the query job call with an error counter
- a link that includes the attempts, materialization, incremental resource type & node name
- add it as an info log
I think your approach is great but it might require some changes:
- Do you think we could align the info in the error log too? I think it's fine to log it twice to easily find the job link in case of error.
- the error counter starts at 0 which is kind of weird to me, what about making it start at 1 and stop after 2 retries (so 3 total)? Maybe even make it a configurable thing but I guess it's more work than needed so far.
- Is it catching all errors? For instance, if I have a SQL or runtime BQ error and it fails, will it start and retry it on every dbt run? I think most people would rather avoid that behavior. So I'm bit worried about introducing that retry especially since 1.6 introduces already
dbt retry
. - If you're adding this log, you should remove https://github.com/dbt-labs/dbt-bigquery/blob/main/dbt/adapters/bigquery/connections.py#LL537C4-L537C4 as it would be obsolete then
@@ -0,0 +1,6 @@ | |||
kind: Features | |||
body: Provide bigquery job link after it's submitted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to proactively update the changelog entry for this PR to be more precise. I will commit (rather than just suggest) with the intent that we can improve it further as-needed.
body: Provide bigquery job link after it's submitted | |
body: Retry query jobs and use info-level logging for job link, etc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: I can't push commits to this branch, so I'll just make this a blocking review instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tbog357 A handful of things for you to do:
- Open a feature request for converting from debug-level to info-level (c.f. here)
- Open a feature request for retrying query jobs
- Update the changelog entry to reflect those two feature request issue numbers (and removing 696 which was already resolved)
- Update the changelog entry description here
Both of those feature requests will need to be approved by our product team (i.e., @Fleid or @dataders)
Hi @dbeatty10 , thanks for reminding me
But the PR of @github-christophe-oudar (#697) suited my need. So I will close this PR Thanks all |
resolves #696
Description
Improve productivity, provide the Bigquery job's link just after it's submitted. Make it easier to find the executed queries
Example of logs proposal
Checklist
changie new
to create a changelog entry