Update for Python3 and masOS Monterey #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on outputs from Alfred itself
|
Thank you! |
|
Thanks! Confirmed working here. |
|
Confirming the works as expected. Thanks a lot for the rewrite! @deanishe WDYT about merging this and releasing a new major version? |
|
Thanks for this! |
|
Thanks a lot! |
|
Thankyou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As guys already noticed here #12 , in recent macOS update this workflow has been broken because Python 2 was removed.
I tried to fix it and looks like succeed.
A huge thanks to @mesozoic for this PR Python 3 support [WIP] alfred-workflow#184. I used his code to update Workflow lib.
Current version has an extra code to work with clipboard privately. It requires special lib, that were shipped with macos but not anymore. I decided to switch to Alfred's clipboard functionality. It now has a checkbox for private copy. I think it means, that old Alfred versions are not supported anymore.
I also decided to remove Notify app that were shipped with workflow and switch to Alfred's notifications.
I switch python in path to
/usr/lib/python3, so support of old macOS versions without Python 3 can result be dropped as well.Direct link to updated workflow
https://github.com/otsec/alfred-pwgen/raw/python3/Password-Generator-3.0.0-alpha-1.alfredworkflow