DBZ-8307 Fix loss data issue for RabbitMQ #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Qwedir Thanks, LGTM. Could you please solve the problem for |
|
@jpechane I understand and see the issue. |
jpechane
reviewed
Nov 6, 2024
| committer.markBatchFinished(); | ||
| } | ||
| else { | ||
| LOGGER.error("Batch processing was incomplete due to record processing errors."); |
There was a problem hiding this comment.
I believe an exception should be thrown here.
|
|
||
| committer.markProcessed(record); | ||
| if (!latch.await(producerConfirmTimeout, TimeUnit.SECONDS)) { |
There was a problem hiding this comment.
IMHO we need a new config option for this wait set to a larger default value as timeout for sending a single message could be different to sending a batch.
…itMqStreamNativeChangeConsumer.handleBatch
|
@Qwedir Applied, thanks! Could you please add a change to the docs too? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done based on the principle of: #96
Link issue:
https://issues.redhat.com/browse/DBZ-8307