-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBZ-6703 Support native RabbitMQ Streams #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahmedrachid Thanks for the PR. Unfortunately Pubsub/PubSubLite testing is not working as intended so your PR will need to take a bit different approach to it.
I left couple of comments on what has to be changed to get everything running.
The key thing you need to remeber is using the system properties -Ddebezium.sink.type=rabbitmqstream -Dtest.type=IT
when running RabbitMqStreamIT
and the need to change the configuration in a way I commented on test config source.
That way you should get it running correctly for the new implementation and test.
When done we'll discuss what is necessary to be done in pom.xml
to make sure that with Maven build both the old and new tests are executed and properly configured.
debezium-server-rabbitmq/src/test/java/io/debezium/server/rabbitmq/RabbitMqContainer.java
Show resolved
Hide resolved
debezium-server-rabbitmq/src/test/java/io/debezium/server/rabbitmq/RabbitMqStreamIT.java
Outdated
Show resolved
Hide resolved
...erver-rabbitmq/src/test/java/io/debezium/server/rabbitmq/RabbitMqStreamTestConfigSource.java
Outdated
Show resolved
Hide resolved
...r-rabbitmq/src/main/java/io/debezium/server/rabbitmq/RabbitMqStreamNativeChangeConsumer.java
Show resolved
Hide resolved
Hello @jpechane , changes/fix for issues are made: i'm running my test in this way: -ea -Ddebezium.sink.type=rabbitmqstream -Dtest.type=IT -Ddebezium.sink.rabbitmqstream.stream=testc.inventory.customers Could you please review ? |
@ahmedrachid I did few changes and made sure the tests are executted as part of the build. PR applied, thanks a lot! |
Great news ! thanks @jpechane |
Related feature request: https://issues.redhat.com/browse/DBZ-6703
Description:
The goal of this PR is to add and support native RabbitMQ Streams in the Debezium server. It includes a new integration module leveraging RabbitMQ Streams Java API, new configuration called "rabbitmqstream" and tests.
Value Added: