Avoid proxying html through asset (#947)

* Avoid proxying html through asset Signed-off-by: Marcos Candeia <[email protected]> * Use forbidden from deco Signed-off-by: Marcos Candeia <[email protected]> --------- Signed-off-by: Marcos Candeia <[email protected]>
deco-cx · Oct 28, 2024 · 8f1a9e0 · 8f1a9e0
1 parent 55ea8a9
commit 8f1a9e0
Showing 1 changed file with 37 additions and 5 deletions.
diff --git a/website/loaders/asset.ts b/website/loaders/asset.ts
@@ -1,22 +1,54 @@
+import { forbidden } from "@deco/deco";
 import { fetchSafe, STALE } from "../../utils/fetch.ts";
-import { shortcircuit } from "@deco/deco";
 interface Props {
   /**
    * @description Asset src like: https://fonts.gstatic.com/...
    */
   src: string;
 }
-const loader = async (props: Props) => {
+
+const loader = async (props: Props, request: Request): Promise<Response> => {
   const url = new URL(props.src);
-  if (url.protocol === "file:") {
-    shortcircuit(new Response("Forbidden", { status: 403 }));
+
+  // Whitelist allowed protocols
+  const allowedProtocols = ["https:", "http:"];
+  if (!allowedProtocols.includes(url.protocol)) {
+    forbidden({
+      message: "Only HTTP and HTTPS protocols are allowed",
+    });
   }
+
   const original = await fetchSafe(url.href, STALE);
   const response = new Response(original.body, original);
+
+  // Check if the request's Accept header includes "text/html"
+  const acceptHeader = request.headers.get("accept");
+  if (acceptHeader && acceptHeader.includes("text/html")) {
+    forbidden({
+      message: "Forbidden: text/html not accepted",
+    });
+  }
+
+  const contentType = response.headers.get("Content-Type");
+  if (contentType && contentType.includes("text/html")) {
+    forbidden({
+      message: "Forbidden: text/html not accepted as a response",
+    });
+  }
+
+  // Set strict Content-Security-Policy
+  response.headers.set(
+    "Content-Security-Policy",
+    "default-src 'none'; style-src 'unsafe-inline'",
+  );
+
+  // Set cache control headers
   response.headers.set(
-    "cache-control",
+    "Cache-Control",
     "public, s-maxage=15552000, max-age=15552000, immutable",
   );
+
   return response;
 };
+
 export default loader;