-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: quorum text #2695
fix: quorum text #2695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, my bad. I'm not feeling good about the UX in this PR tho. Here is a draw of our progress bar with the changes made by this PR: While the progress bar max value is the number of votes to reach quorum, the text is displaying votes casted / eligible votes. Pretty confusing. I suggest we go ahead and implement two bars, one for quorum and one for % of votes. Like @linnutee proposed here: #2704. We can get rid of the quorum bar once its reached and show a |
I like linutee's suggestion. |
I think you guys are making this way more complicated than it needs to be. The text from the orignal comment is simple and intuitive. A normal person is going to see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented there in #2704 that adding that two separate bars makes only sense in a proposal specific view. That one has the real-estate to include all the details to make it clear enough. Otherwise much repetition in proposals list view, as that's much more packed already. I'd go for a more reductive approach in the prop. list view. Though this is quite dated https://voting.decred.org/ I think solving it with either some icon block as part of the status group, rather than yes/no voting would be optimal. Previous screenshot from Luke is in a sense simple, but adds too much different type styles w/o alignment. Couple quick drafts to test and validate https://www.figma.com/file/igi4pdXlHhTiGyDIF9A2IR/dcr---design-guidelines---id-and-visual-comms?node-id=2%3A7429 : |
Closes #2687
Dependencies
Depends on decred/pi-ui#412
UI Changes Screenshot
Desktop
Mobile