Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quorum text #2695

Merged
merged 4 commits into from
Jan 20, 2022
Merged

fix: quorum text #2695

merged 4 commits into from
Jan 20, 2022

Conversation

tiagoalvesdulce
Copy link
Member

Closes #2687

Dependencies

Depends on decred/pi-ui#412

UI Changes Screenshot

Desktop
Screen Shot 2021-12-20 at 09 21 35

Mobile
Screen Shot 2021-12-20 at 09 48 59

Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This is not showing the total eligible votes. This should say 2/5353 votes.

@tiagoalvesdulce
Copy link
Member Author

Right, my bad.

I'm not feeling good about the UX in this PR tho. Here is a draw of our progress bar with the changes made by this PR:

Screen Shot 2022-01-17 at 17 42 24

While the progress bar max value is the number of votes to reach quorum, the text is displaying votes casted / eligible votes. Pretty confusing.

I suggest we go ahead and implement two bars, one for quorum and one for % of votes. Like @linnutee proposed here: #2704. We can get rid of the quorum bar once its reached and show a quorum reached text. What do you think @victorgcramos @lukebp @amass01 ?

@victorgcramos
Copy link
Member

I like linutee's suggestion.

@victorgcramos
Copy link
Member

See how it looks if we split the view and place the status bars side by side:
Screen Shot 2022-01-17 at 6 50 25 PM

@lukebp
Copy link
Member

lukebp commented Jan 17, 2022

I think you guys are making this way more complicated than it needs to be. The text from the orignal comment is simple and intuitive.

#2687 (comment)

A normal person is going to see 100/5000 as the number of votes that have been cast out of the total number of possible votes. The number of votes until quorum is reached is also displayed. This lines up with the status bar.

Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK
image

@tiagoalvesdulce tiagoalvesdulce merged commit 7fe2ff3 into decred:master Jan 20, 2022
@tiagoalvesdulce tiagoalvesdulce added the pi-not-deployed This item has been merged into master, but has not been deployed to production yet. label Jan 20, 2022
@ta-lind
Copy link
Member

ta-lind commented Jan 28, 2022

I commented there in #2704 that adding that two separate bars makes only sense in a proposal specific view. That one has the real-estate to include all the details to make it clear enough. Otherwise much repetition in proposals list view, as that's much more packed already.

I'd go for a more reductive approach in the prop. list view. Though this is quite dated https://voting.decred.org/ I think solving it with either some icon block as part of the status group, rather than yes/no voting would be optimal. Previous screenshot from Luke is in a sense simple, but adds too much different type styles w/o alignment.

Couple quick drafts to test and validate https://www.figma.com/file/igi4pdXlHhTiGyDIF9A2IR/dcr---design-guidelines---id-and-visual-comms?node-id=2%3A7429 :
Screenshot 2022-01-28 at 15 21 02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pi-not-deployed This item has been merged into master, but has not been deployed to production yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quorum text improvement on mobile
4 participants