feat: accordion #1075
Draft
feat: accordion #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
requested changes
Jan 10, 2025
mofojed
requested changes
Jan 22, 2025
Comment on lines
+23
to
+37
| @ui.component | ||
| def ui_accordion_event(): | ||
| expanded_keys, set_expanded_keys = ui.use_state([]) | ||
|
|
||
| def handle_expanded_keys_change(e): | ||
| set_expanded_keys(e) | ||
| print("Expanded key changed") | ||
|
|
||
| return ui.accordion( | ||
| ui.disclosure(title="FAQ #1", panel="Answer", id="a"), | ||
| ui.disclosure(title="FAQ #2", panel="Answer", id="b"), | ||
| expanded_keys=expanded_keys, | ||
| on_expanded_change=lambda k: set_expanded_keys(k), | ||
| ) | ||
|
|
There was a problem hiding this comment.
Instead of printing to console, we should just show it underneath. e.g.
Suggested change
| @ui.component | |
| def ui_accordion_event(): | |
| expanded_keys, set_expanded_keys = ui.use_state([]) | |
| def handle_expanded_keys_change(e): | |
| set_expanded_keys(e) | |
| print("Expanded key changed") | |
| return ui.accordion( | |
| ui.disclosure(title="FAQ #1", panel="Answer", id="a"), | |
| ui.disclosure(title="FAQ #2", panel="Answer", id="b"), | |
| expanded_keys=expanded_keys, | |
| on_expanded_change=lambda k: set_expanded_keys(k), | |
| ) | |
| @ui.component | |
| def ui_accordion_event(): | |
| expanded_keys, set_expanded_keys = ui.use_state([]) | |
| return ui.view( | |
| ui.accordion( | |
| ui.disclosure(title="FAQ #1", panel="Answer", id="a"), | |
| ui.disclosure(title="FAQ #2", panel="Answer", id="b"), | |
| expanded_keys=expanded_keys, | |
| on_expanded_change=set_expanded_keys, | |
| ), | |
| ui.heading("Currently expanded: ", expanded_keys) | |
| ) | |
Also we should have better/different content for each, and the id should match the disclosure titles.
| ) | ||
|
|
||
|
|
||
| my_accordion_event = ui_accordion_event() |
There was a problem hiding this comment.
Should an example with allows_multiple_expanded as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18136
Wait for ui.disclosure to merge