Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Long dashboard titles overflow the navbar tab #2348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ericlln
Copy link
Contributor

@ericlln ericlln commented Jan 23, 2025

  • Moved the title into its own element in the navbar tab so that text-overflow: ellipsis would work properly.
  • Tested by creating dashboards with both long and short titles to confirm that long titles are truncated with ellipses, and short titles display in the same way as before.

@ericlln ericlln requested a review from mofojed January 23, 2025 17:04
@ericlln ericlln self-assigned this Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.74%. Comparing base (bbba404) to head (9166749).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2348   +/-   ##
=======================================
  Coverage   46.74%   46.74%           
=======================================
  Files         705      705           
  Lines       39054    39054           
  Branches     9762     9762           
=======================================
  Hits        18256    18256           
  Misses      20787    20787           
  Partials       11       11           
Flag Coverage Δ
unit 46.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed requested review from dsmmcken and removed request for mofojed January 27, 2025 15:54
@mofojed
Copy link
Member

mofojed commented Jan 27, 2025

I'm assigning @dsmmcken for review as this is mainly a styling thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants