Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added trusted hosts necessary for istio ambient #299

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sgettys
Copy link

@sgettys sgettys commented Jan 9, 2025

Description

adds trusted host for istio ambient with ztunnel (".pepr-uds-core-watcher.pepr-system.svc.cluster.local") and istio ambient with waypoint (".keycloak.svc.cluster.local")

Ambient traffic with only ztunnel will show as coming from the pepr pod directly since it only does L4 routing and connects directly to the Keycloak pod. Ambient traffic when Waypoint is deployed for Keycloak shows as originating from the Keycloak Waypoint proxy.

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@sgettys sgettys requested a review from a team as a code owner January 9, 2025 00:17
@sgettys sgettys changed the title fix: added trusted hosts necessary for istio ambient feat: added trusted hosts necessary for istio ambient Jan 9, 2025
Copy link
Contributor

@UnicornChance UnicornChance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense and shouldn't hurt anything, but we may need to try and find a way to do this on an upgrade (the realm is only imported at install), potentially with Terraform + manual upgrade docs (two options). That could be a follow on PR if we want though.

@UnicornChance
Copy link
Contributor

That's a good call i didn't consider @mjnagel. This is where we've been documenting upgrade steps that require manual intervention, if we go that route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants