bugfix: prevent monitor exception spin loop when MongoDB unreachable. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha, the travis integration on PRs is funny. Looks like maybe the |
|
Hey... thx for the patch! I will try to get it merged/released this weekend. |
| LOG.log(Level.SEVERE, t.getMessage(), t); | ||
| } | ||
| } while (!_shutdown.await(awaitMillis(), TimeUnit.MILLISECONDS)); | ||
| } catch (InterruptedException ignored) { |
|
One tiny fix. Otherwise... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Deftlabs!
Currently with the
sleepoccurs after the MongoDB calls, the background threads will sit in a verbose exception loop while the MongoDB is down. This change ensures the sleep occurs on exception, but still eagerly attempts the cleanup at startup.Thanks!
@john-morales