-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mapbox hpp skel #6
Conversation
…google benchmark, fixed various configuration issues, moved the namespace some
@flippmoke what was the motivation to change |
@delfrrr the original thought was to make it a struct and then simply migrate over time the methods to act on it instead of acting on private values within the struct. The reason for this was that there is very limited information that is actually required at the end and some variables are just needed within the struct itself. If you wish to make it back into a class that is fine, but I think currently the struct stores too much extra information that isn't required after the algorithm is run. |
@flippmoke ah so you suggest instead of using private properties pass them as references to the parameters of the methods? and move methods to static functions? so at the end it can be just a static function which returns struct with triangles and half-edges? I think It's not bad idea; but it's also true for JS version (cc @mourner); I'm trying to keep close to JS version so I can move updates to cpp version. I added separate issue #7 for this. For now having struct with private members does not make sense for me. |
@flippmoke any particular reason for |
Based on PR from @flippmoke #3