Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase test coverage #87

Merged
merged 1 commit into from
Jan 15, 2024
Merged

chore: increase test coverage #87

merged 1 commit into from
Jan 15, 2024

Conversation

deer
Copy link
Contributor

@deer deer commented Jan 15, 2024

towards #50

@hashrock, please take a look.

Additionally there's something strange going on with the coverage. It's reporting that

  image(src: string, title: string | null, alt: string | null) {
    return `<img src="${src}" alt="${alt ?? ""}" title="${title ?? ""}" />`;
  }

isn't covered, even though this is definitely executed. There are a few other spots that have the same problem.

@hashrock
Copy link
Contributor

awesome thank you deer!
I find it strange too, but I'll keep it in mind

@hashrock hashrock merged commit 6b01882 into denoland:main Jan 15, 2024
1 check passed
@deer deer deleted the tests branch January 15, 2024 18:49
@deer
Copy link
Contributor Author

deer commented Jan 17, 2024

@hashrock, do you know if there's an issue for this coverage problem in https://github.com/denoland/deno? To clarify: if I set a breakpoint within

  image(src: string, title: string | null, alt: string | null) {
    return `<img src="${src}" alt="${alt ?? ""}" title="${title ?? ""}" />`;
  }

it catches during the test, but the coverage report shows it as uncovered.

If you don't know of one, then I'll log an issue. (I've checked myself, and I don't see one, but maybe I'm missing something.)

@hashrock
Copy link
Contributor

@deer sorry. I don't usually use the coverage command, so I don't know if there are similar issues. I did a quick search but couldn't find any similar issues, so please feel free to file new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants