Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Standardize phone number entry in Drupal interfaces #17854

Open
jilladams opened this issue Apr 15, 2024 · 4 comments
Open

[EPIC] Standardize phone number entry in Drupal interfaces #17854

jilladams opened this issue Apr 15, 2024 · 4 comments
Labels
Drupal engineering CMS team practice area Epic Issue type Facilities Facilities products (VAMC, Vet Center, etc) Lighthouse Facility API Data source/destination for many Facilities team products Public Websites Scrum team in the Sitewide crew Regional office CMS managed VBA product owned by the Facilities team Sitewide Priority This label should be used only on Epics that are currently priorities for the Sitewide team sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team Vet Center CMS managed product owned by Facilities team

Comments

@jilladams
Copy link
Contributor

jilladams commented Apr 15, 2024

Update 7/18/2024: Renaming this epic to better reflect the specific set of work we will be tackling and changing to be Sitewide rather than Facilities - @davidmpickett

Background

Historically we allowed Drupal editors to enter phone number into a phone number Field field_phone_number that allowed for a wide range of input. (This is on VAMC facilities primarily. VAMC Health Services already use the phone number paragraph type, and will not be addressed in this epic.)

We later developed the phone number Paragraph Type paragraphs_type/phone_number which breaks down the components of phone numbers into separate input fields so that the FE can better parse the data and pass it to the Design System Component.

Example of phone Field

351116522-781cf96b-d5cf-49df-a6b3-4a7aa5c86ea2

Example of phone Paragraph Type

Screenshot 2024-07-22 at 4 21 42 PM

The Work

  • Updating various Drupal interfaces to use the Paragraph Type instead of the Field
    • Migrating existing data
    • Updating Drupal interface
    • Updating FE query and template
    • Removing old Drupal field
  • Upgrading the Phone Number Paragraph Type to handle additional use cases
    • Better validation of sub fields like Extension
    • New sub fields like Vanity & International

The Impact

  • Allows us to finish Design System component adoption on our products
  • Improves guardrails in Drupal to prevent editor errors
  • Results in more reliable experience for Veterans on various products
@jilladams jilladams added Needs refining Issue status VAMC CMS managed product owned by Facilities team VA.gov frontend CMS team practice area Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team Vet Center CMS managed product owned by Facilities team UX labels Apr 15, 2024
@jilladams jilladams changed the title SE: Faciliites Phone Number issues SE: Faciliites Phone Number issues from Drupal fields Apr 15, 2024
@jilladams jilladams added the Lighthouse Facility API Data source/destination for many Facilities team products label Apr 15, 2024
@jilladams jilladams added the Epic Issue type label Apr 15, 2024
@jilladams jilladams changed the title SE: Faciliites Phone Number issues from Drupal fields SE: Drupal Phone number fields on Facilities content types Apr 15, 2024
@davidmpickett
Copy link
Contributor

davidmpickett commented Jul 18, 2024

@Agile6MSkinner @mmiddaugh @jilladams
I want to note that while the tickets that are in this epic are tightly scoped around improving one Drupal "component" across multiple products, this epic also currently includes another epic which is very product specific (Mental Health Phone Numbers).

Would be good to clarify if the remaining parts of #9717 are part of the Q3 priority, or if that's just a vestige of how we originally organized this.

Edit I went ahead and made that change and also retitled this epic so it can include non-facilities tickets like #17326

@davidmpickett davidmpickett changed the title SE: Drupal Phone number fields on Facilities content types Standardize phone number entry fields on Sitewide Drupal interfaces Jul 18, 2024
@davidmpickett davidmpickett added Public Websites Scrum team in the Sitewide crew and removed Needs refining Issue status labels Jul 18, 2024
@davidmpickett davidmpickett changed the title Standardize phone number entry fields on Sitewide Drupal interfaces Standardize phone number entry in Drupal interfaces Jul 24, 2024
@davidmpickett
Copy link
Contributor

davidmpickett commented Jul 25, 2024

Brief notes from a prefinement meeting today:

  • We think it make sense for @jv-agile6 to be the primary engineer for this epic (with copious support)
  • The question of whether it makes sense to do 17861 or 17863 first is really a matter of preference rather than necessity
  • @davidmpickett structured 17861 to have a comprehensive view of both the Drupal and FE work required. That may or may not be the way that makes sense to do it, might end up being broken back down into Drupal and FE
  • Additional engineering conversations will happen to further refine tickets
  • Once a pattern is established for 17861, that should be applied to other tickets in this epic

@jilladams jilladams changed the title Standardize phone number entry in Drupal interfaces [EPIC] Standardize phone number entry in Drupal interfaces Oct 23, 2024
@jilladams
Copy link
Contributor Author

jilladams commented Nov 26, 2024

As far as finishing out this epic, there were 3 tickets missing to clean up feature toggle/Drupal tech debt. I just created:

@davidmpickett davidmpickett added Sitewide Priority This label should be used only on Epics that are currently priorities for the Sitewide team and removed UX labels Jan 2, 2025
@Agile6MSkinner
Copy link

I will make stories for migration and change management for exts with alph characters and add them to this epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Epic Issue type Facilities Facilities products (VAMC, Vet Center, etc) Lighthouse Facility API Data source/destination for many Facilities team products Public Websites Scrum team in the Sitewide crew Regional office CMS managed VBA product owned by the Facilities team Sitewide Priority This label should be used only on Epics that are currently priorities for the Sitewide team sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team Vet Center CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

3 participants