Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Build Template: News Release #19576

Open
14 of 30 tasks
gracekretschmer-metrostar opened this issue Oct 22, 2024 · 7 comments
Open
14 of 30 tasks

Next Build Template: News Release #19576

gracekretschmer-metrostar opened this issue Oct 22, 2024 · 7 comments
Labels
Accelerated Publishing Migration CMS practice area News release CMS managed product owned by Facilities team VAMC CMS managed product owned by Facilities team

Comments

@gracekretschmer-metrostar
Copy link

gracekretschmer-metrostar commented Oct 22, 2024

Template or Content Type

News Release

Example

https://dev.va.gov/southern-nevada-health-care/news-releases/va-southern-nevada-healthcare-system-to-host-annual-veterans-appreciation-day-car-show-bbq/

Description

Overview of template or content type, including relevant details to the migration lift.

Owning Team

  • CMS team
  • Sitewide
  • IIR

Definition of Done

Data:

  • Conditional logic matches content-build / production
  • SEO Metadata matches production
  • Analytics match production

Interaction / Behavior:

  • Interactions / behavior match production (e.g. accordion expansion by default on page load if they do, data IDs on elements / their usage, link behavior, form / input field behaviors, etc)
  • Lovell Logic: Do the Tricare (/lovell-federal-health-care-tricare/) and VA (/lovell-federal-health-care-va/) variants of each page have the proper System in the
    • alert
    • URL
    • breadcrumbs
    • left nav
  • VA Manila (/manila-va-clinic): do the pages appear properly and respect the custom IA, including:
    • URL
    • breadcrumbs
    • left nav

Accessibility:

  • Accessibility experience matches production (voiceover/screen reader behavior, appearance at 400% zoom, params on elements, etc)
  • axe devTools output matches production

Visual presentation:

  • Design system components, prop usage and component versions match production
  • Design (font size, spacing, Anything else?) matches production
  • Review all breakpoints

Signoff / Launch

  • Owning team has reviewed the build and provided feedback / approval
  • CMS Team has confirmed launch readiness

ADDITIONAL CHILDREN

The tickets below also were found during QA of this product template, but apply to multiple products, so are listed in the cross-product epic, #20178.

@jilladams jilladams added VAMC CMS managed product owned by Facilities team Migration CMS practice area Accelerated Publishing News release CMS managed product owned by Facilities team labels Nov 4, 2024
@jilladams
Copy link
Contributor

Verifying Manila will be blocked on #19570

@jilladams
Copy link
Contributor

To my knowledge we haven't been provided a build of News Releases to review. (I know News Release Listings was noted as ready for review, but there too, we weren't sure where to find it to review, noted here.)

@laflannery
Copy link
Contributor

laflannery commented Dec 24, 2024

Noting for future selves:

  • Currently on the content-build templates, there is an empty <nav> element that causes accessibility issues (See ticket for more details). This has been removed from next-build so I'm going to close that Sitewide ticket
  • Manila does not currently have any News release details so this wasn't able to be tested. It's just something we will have to pay attention to when they do add some, if this happens between the QA time and the launch time

@laflannery
Copy link
Contributor

@jilladams This should be all done but there are some global issues that I don't know if I need to re-ticket? Should I just list them all in a comment or something?

@jilladams
Copy link
Contributor

No dupe tickets, pls. If you find that a global issue is present on the Next build of a product, can you make sure that the product and next-build are added to the global ticket as labels? ANd yea, maybe just link those tickets on the relevant epic for the Next version of the product.

@jilladams
Copy link
Contributor

And if that doesn't make any sense, let's chat for a min to figure it out.

@jilladams
Copy link
Contributor

@EWashb @mmiddaugh @gracekretschmer-metrostar : Sitewide has completed testing News Releases, and filed all our issues with suggestions about Must / Should / Consider. THey're linked in the Epic as sub-issues if they applied only to News Releases, and in the "Additional Children" section of the ticket body if they happen on more content types than just News Releases.

I'm not sure we have a Go / No Go process yet. Let me / @laflannery know if you'd like a live review of the opened tickets, to decide if y'all agree on the Musts that would block launch. If we also want to talk ownership of blocking issues, we should include @Agile6MSkinner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accelerated Publishing Migration CMS practice area News release CMS managed product owned by Facilities team VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

3 participants