Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global - Markup for banners has incorrect ARIA #20161

Open
3 tasks
Tracked by #20313 ...
laflannery opened this issue Dec 23, 2024 · 2 comments
Open
3 tasks
Tracked by #20313 ...

Global - Markup for banners has incorrect ARIA #20161

laflannery opened this issue Dec 23, 2024 · 2 comments
Assignees
Labels
Accelerated Publishing Defect Something isn't working (issue type) next-build FE Repository that will replace content-build. Uses NextJS, builds static pages.

Comments

@laflannery
Copy link
Contributor

laflannery commented Dec 23, 2024

Description

The markup for the banners used within next-build have incorrect ARIA (role and aria-label) that need to be removed

  1. Both the facilities banners and the Sitewide banners are using the <va-banner> component however they also both have a role attribute that should not be present. The role is inside the element, within the shadow DOM and should not be duplicated here.

Image

- The `role` needs to be removed from [the facilities banner file](https://github.com/department-of-veterans-affairs/next-build/blob/main/src/templates/common/banners/facilityBanner/index.tsx)
- The `role` needs to be removed from [the sitewide banner file](https://github.com/department-of-veterans-affairs/next-build/blob/main/src/templates/common/banners/banner/index.tsx)
  1. The <div> for the maintenance banner has an incorrect role and aria-label that both need to be removed from this file
    Image

  2. The promo banner also has an incorrect role that needs to be removed from this file

Acceptance Criteria

  • Remove role="region" from all banners markup in next-build
  • Remove aria-label attribute from Maintenance Banner div in next-build
  • Accessibility review from @laflannery
@laflannery laflannery added Accelerated Publishing Defect Something isn't working (issue type) Facilities Facilities products (VAMC, Vet Center, etc) sitewide Public Websites Scrum team in the Sitewide crew VA.gov frontend CMS team practice area next-build FE Repository that will replace content-build. Uses NextJS, builds static pages. labels Dec 23, 2024
@laflannery laflannery changed the title Must: Markup for banners has incorrect ARIA Must: Global - Markup for banners has incorrect ARIA Dec 23, 2024
@jilladams jilladams added the News release CMS managed product owned by Facilities team label Dec 24, 2024
@FranECross FranECross changed the title Must: Global - Markup for banners has incorrect ARIA [AP TEAM] Must: Global - Markup for banners has incorrect ARIA Jan 15, 2025
@laflannery
Copy link
Contributor Author

@jilladams and @FranECross and @gracekretschmer-metrostar, This is a ticket regarding next-build templates. I'm not sure that this should be looked at/worked on by Sitewide at this time. I think it's a question of CMS still needing to determine a process and ownership of the migration work before this moves forward. Let me know if I'm incorrect obviously CC: @Shamiaalam

@jilladams
Copy link
Contributor

That's where we landed during refinement as well. For now we said: we'll leave it where it is until the AP team is spun up and we can figure out where / how Sitewide can best support.

@laflannery laflannery removed Facilities Facilities products (VAMC, Vet Center, etc) Public Websites Scrum team in the Sitewide crew sitewide News release CMS managed product owned by Facilities team Transfer labels Jan 22, 2025
@laflannery laflannery changed the title [AP TEAM] Must: Global - Markup for banners has incorrect ARIA Global - Markup for banners has incorrect ARIA Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accelerated Publishing Defect Something isn't working (issue type) next-build FE Repository that will replace content-build. Uses NextJS, builds static pages.
Projects
None yet
Development

No branches or pull requests

5 participants