VACMS-13613 and 8017 Add PostFacilityBase methods #13776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swirtSJW
commented
May 21, 2023
Comment on lines
-225
to
-247
| /** | ||
| * Get operating status details, shortened as necessary. | ||
| * | ||
| * @return string | ||
| * Details of operating status. | ||
| */ | ||
| protected function getOperatingStatusMoreInfoShort() : ?string { | ||
| $operatingStatusMoreInfo = $this->facilityNode->get('field_operating_status_more_info')->value; | ||
| if ($operatingStatusMoreInfo) { | ||
| $operatingStatusMoreInfo = $this->facilityNode->get('field_operating_status_more_info')->value; | ||
| $operatingStatusMoreInfoJson = json_encode($this->facilityNode->get('field_operating_status_more_info')->value); | ||
| $operatingStatusMoreInfoLength = mb_strlen($operatingStatusMoreInfoJson); | ||
| // 300 is the character limit for field_operating_status_facility | ||
| // let's do our best to trim this down if we need to | ||
| if ($operatingStatusMoreInfoLength > 300) { | ||
| $operatingStatusMoreInfo = str_replace(' ', ' ', $operatingStatusMoreInfo); | ||
| $operatingStatusMoreInfo = trim($operatingStatusMoreInfo); | ||
| $operatingStatusMoreInfo = preg_replace("/(\r?\n|\r)+/", " ", $operatingStatusMoreInfo); | ||
| } | ||
| } | ||
| return $operatingStatusMoreInfo; | ||
| } | ||
|
|
There was a problem hiding this comment.
Moved this to Base because VetCenter CAPs are going to need it too.
swirtSJW
force-pushed
the
VACMS-13613-and-8017-add-pushfaacilitybase-methods
branch
from
4c65d32 to
df67f24
Compare
swirtSJW
added
Facilities
swirtSJW
force-pushed
the
VACMS-13613-and-8017-add-pushfaacilitybase-methods
branch
from
df67f24 to
dd6d35d
Compare
swirtSJW
force-pushed
the
VACMS-13613-and-8017-add-pushfaacilitybase-methods
branch
from
dd6d35d to
d3c9f02
Compare
swirtSJW
force-pushed
the
VACMS-13613-and-8017-add-pushfaacilitybase-methods
branch
from
d3c9f02 to
d3f4177
Compare
These methods are not being used yet, but they will be used by two different PRs for Lighthouse that we can not control when they will land. Adding these here now in andvance helps avoid conflct.
swirtSJW
force-pushed
the
VACMS-13613-and-8017-add-pushfaacilitybase-methods
branch
from
d3f4177 to
c03e548
Compare
|
|
omahane
reviewed
May 22, 2023
docroot/modules/custom/va_gov_post_api/src/Service/PostFacilityBase.php
Outdated
Show resolved
Hide resolved
docroot/modules/custom/va_gov_post_api/src/Service/PostFacilityBase.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Christian Burk <[email protected]>
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are not being used yet, but they will be used by two different PRs for Lighthouse that we can not control when they will land. Adding these here now in andvance helps avoid conflct.
Description
Relates to #13613
Relates to #8017
Testing done
Code is not being used. Testing will come when either of the PRs that use it are reviewed.
Screenshots
QA steps
This code is not being used. Testing will come when either of the PRs that use it are reviewed.