Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-13613 Add VetCenter CAP data push. #13777

Conversation

swirtSJW
Copy link
Contributor

@swirtSJW swirtSJW commented May 21, 2023

Descriptio

Relates to #13613

Blocked

This is currently blocked by Lighthouse not having an endpoint that we can push this data to. We currently have no place to push this data to. Once Lighthouse builds and endpoint to receive this data, which hopefully will be the same endpoint we need to push VBA data, then we can proceed with test pushes to make sure they receive it.

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing annoucement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 21, 2023 02:58 Destroyed
@swirtSJW swirtSJW self-assigned this May 21, 2023
@swirtSJW swirtSJW added Facilities Facilities products (VAMC, Vet Center, etc) Vet Center CMS managed product owned by Facilities team Lighthouse Facility API Data source/destination for many Facilities team products DO NOT MERGE Do not merge this PR Awaiting Official Launch Code is approved and ready for merge, but needs a launch. labels May 21, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 22, 2023 04:35 Destroyed
swirtSJW added 3 commits May 22, 2023 00:39
These methods are not being used yet, but they will be used by two
different PRs for Lighthouse that we can not control when they
will land.  Adding these here now in andvance helps avoid conflct.
@swirtSJW swirtSJW force-pushed the VACMS-13613-cap-data-push branch from 61d22c6 to 2392b07 Compare May 22, 2023 04:42
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 22, 2023 04:42 Destroyed
@jilladams
Copy link
Contributor

@swirtSJW can you update this PR with what the steps are to unblock merging it?

Removing sprint.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 5, 2023 20:16 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 7, 2023 15:53 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 29, 2023 23:26 Destroyed
@mmiddaugh
Copy link
Contributor

@swirtSJW is this work dependent on #14083 Upgrade Address module to version 2?

@swirtSJW
Copy link
Contributor Author

swirtSJW commented Jan 5, 2024

@swirtSJW is this work dependent on #14083 Upgrade Address module to version 2?

@mmiddaugh It is not dependent on 14083, however if 14083 were to land first, this code would likely need to be adjusted in the same way our other code needs adjusting.

@swirtSJW
Copy link
Contributor Author

swirtSJW commented Jan 5, 2024

@swirtSJW can you update this PR with what the steps are to unblock merging it?

@jilladams Sorry I missed this. I added a "blocked" section to the description

@swirtSJW
Copy link
Contributor Author

swirtSJW commented Jan 5, 2024

@jilladams I need to recreate this PR because currently it is from my fork which will likely disappear in a puff of smoke when they remove me from the repo in Feb.

@swirtSJW
Copy link
Contributor Author

Closing this in favor of #16837 (same code just deconflicted and moved to branch in the primary repository.

@swirtSJW swirtSJW closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Official Launch Code is approved and ready for merge, but needs a launch. DO NOT MERGE Do not merge this PR Facilities Facilities products (VAMC, Vet Center, etc) Lighthouse Facility API Data source/destination for many Facilities team products Vet Center CMS managed product owned by Facilities team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants