Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18701: updated composer dependencies #18707

Conversation

edmund-dunn
Copy link
Contributor

@edmund-dunn edmund-dunn commented Jul 22, 2024

Description

Close #18701

Testing done

Tested locally

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Normally, for these updates, we depend on automated testing, so if all automated testing passes, they should be good.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn self-assigned this Jul 22, 2024
@edmund-dunn edmund-dunn linked an issue Jul 22, 2024 that may be closed by this pull request
1 task
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 22, 2024 19:19 Destroyed
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Jul 22, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 23, 2024 14:14 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 23, 2024 14:26 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 23, 2024 15:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 23, 2024 17:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 23, 2024 17:37 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 23, 2024 17:39 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 24, 2024 13:58 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 24, 2024 15:06 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 24, 2024 15:14 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 24, 2024 16:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 24, 2024 18:32 Destroyed
@edmund-dunn edmund-dunn requested a review from timcosgrove July 24, 2024 19:05
Scenario: Administer user role can add/edit users
Given I am logged in as a user with the "admnistrator_users" role
Given I am logged in as a user with the "administrator_users" role
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, how did our tests ever pass given this error? 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your guess is as good as mine. I talked this through with Jon. We are looking at a way to test these routes outside of cypress, to help get cypress more performant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The role is called admnistrator_users here because that's the machine name of the role in the CMS: https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/config/sync/user.role.admnistrator_users.yml

I don't object to the @ignore but this test would otherwise fail because it's trying to create a user with a non-existent role. We should revert back to the incorrect spelling.

Scenario: Administer user role can add/edit users
Given I am logged in as a user with the "admnistrator_users" role
Given I am logged in as a user with the "administrator_users" role
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The role is called admnistrator_users here because that's the machine name of the role in the CMS: https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/config/sync/user.role.admnistrator_users.yml

I don't object to the @ignore but this test would otherwise fail because it's trying to create a user with a non-existent role. We should revert back to the incorrect spelling.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 24, 2024 19:54 Destroyed
@edmund-dunn edmund-dunn merged commit 9b59d45 into main Jul 24, 2024
19 checks passed
@edmund-dunn edmund-dunn deleted the 18701-doing-mass-composerjson-update-of-packages-to-get-dependapbot-caught-up branch July 24, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doing mass composer.json update of packages to get dependapbot caught up.
3 participants