-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-18701: updated composer dependencies #18707
VACMS-18701: updated composer dependencies #18707
Conversation
Scenario: Administer user role can add/edit users | ||
Given I am logged in as a user with the "admnistrator_users" role | ||
Given I am logged in as a user with the "administrator_users" role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, how did our tests ever pass given this error? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your guess is as good as mine. I talked this through with Jon. We are looking at a way to test these routes outside of cypress, to help get cypress more performant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The role is called admnistrator_users
here because that's the machine name of the role in the CMS: https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/config/sync/user.role.admnistrator_users.yml
I don't object to the @ignore
but this test would otherwise fail because it's trying to create a user with a non-existent role. We should revert back to the incorrect spelling.
Scenario: Administer user role can add/edit users | ||
Given I am logged in as a user with the "admnistrator_users" role | ||
Given I am logged in as a user with the "administrator_users" role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The role is called admnistrator_users
here because that's the machine name of the role in the CMS: https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/config/sync/user.role.admnistrator_users.yml
I don't object to the @ignore
but this test would otherwise fail because it's trying to create a user with a non-existent role. We should revert back to the incorrect spelling.
Description
Close #18701
Testing done
Tested locally
Screenshots
QA steps
What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?
Normally, for these updates, we depend on automated testing, so if all automated testing passes, they should be good.
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing
Is this PR blocked by another PR?
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review
CMS user-facing announcement
Is an announcement needed to let editors know of this change?