VACMS-19616: Contact info block has remove button not working

[dsasser]

Description

Removes the remove button on the contact information paragraph on several content types by making the 'contact information' field required.

Relates to #19616

Testing done

Tested manually and via cypress

Screenshots

QA steps

As a content admin

1. Visit the 'add Checklist' page
   • Validate that there is no 'Remove' button on the Contact Information paragraph.
   • Under 'Select contacts', select the 'Benefit Hub contacts' option.
   • Validate you see the widget change to use the 'Benefit Hub contacts' widget (see above screenshot)
2. Visit the 'add FAQ page' page
   • Validate that there is no 'Remove' button on the Contact Information paragraph.
   • Under 'Select contacts', select the 'Benefit Hub contacts' option.
   • Validate you see the widget change to use the 'Benefit Hub contacts' widget (see above screenshot)
3. Visit the 'add Image List' page
   • Validate that there is no 'Remove' button on the Contact Information paragraph.
   • Under 'Select contacts', select the 'Benefit Hub contacts' option.
   • Validate you see the widget change to use the 'Benefit Hub contacts' widget (see above screenshot)
4. Visit the 'add Video List' page
   • Validate that there is no 'Remove' button on the Contact Information paragraph.
   • Under 'Select contacts', select the 'Benefit Hub contacts' option.
   • Validate you see the widget change to use the 'Benefit Hub contacts' subform (see above screenshot)
5. Visit the 'add Reusable Q&A' page
   • Validate that there is no 'Remove' button on the Contact Information paragraph.
   • Under 'Select contacts', select the 'Benefit Hub contacts' option.
   • Validate you see the widget change to use the 'Benefit Hub contacts' subform (see above screenshot)
6. Visit the 'add Step-by-Step' page
   • Validate that there is no 'Remove' button on the Contact Information paragraph.
   • Under 'Select contacts', select the 'Benefit Hub contacts' option.
   • Validate you see the widget change to use the 'Benefit Hub contacts' subform (see above screenshot)
7. Visit the 'add Resources and Support Detail Page' page
   • Validate that there is no 'Remove' button on the Contact Information paragraph.
   • Under 'Select contacts', select the 'Benefit Hub contacts' option.
   • Validate you see the widget change to use the 'Benefit Hub contacts' subform (see above screenshot)

Definition of Done

• Documentation has been updated, if applicable.
• Tests have been added if necessary.
• Automated tests have passed.
• Code Quality Tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.
• If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[va-cms-bot]

Cypress Accessibility Violations

/test-data-dolorem

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
  Impact: critical
  Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: button[data-proofing-help-title="About 'Main content' field"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"

[omahane]

Works as advertised!