VACMS-19794: Removes Connect with us tech debt

[omahane]

Description

Relates to #19794

Testing done

Cypress
Manual

Screenshots

There should be no discernible difference, now that these hidden fields are removed.

QA steps

The following should look the same:

Content	Prod	Tugboat
Office Edit
CLP Edit
BHLP Edit
Office View
CLP View
BHLP View

Front-end

• Release content
• Campaign Landing Page should be the same
  • https://web-pthfy2lo0vp5txgvmgvwterjp9ctcgax.ci.cms.va.gov/initiatives/protecting-veterans-from-fraud/
    • 
  • https://va.gov/initiatives/protecting-veterans-from-fraud/
    • 
• Compare Benefits Hub Landing Page should be the same
  • https://web-pthfy2lo0vp5txgvmgvwterjp9ctcgax.ci.cms.va.gov/pension/
  • 
  • https://va.gov/pension/
  • 

Back-end

• Check the entity view relationship by editing Events (Note: this is the same view that was being used by the Connect with Us field to find the Office. The display with that entity view has been removed).
• Go to https://pr20303-pthfy2lo0vp5txgvmgvwterjp9ctcgax.ci.cms.va.gov/node/76408/edit
• Search for a different Facility Location
• Confirm that facility locations are listed as you type

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[laflannery]

Just in case it matters in the future, the Twitter links have since been updated form when these screenshots where taken and are now X, just wanted to note this:

[laflannery]

Looks good!

[dsasser]

Changes look great:

[github-actions]

Checking composer.lock changes...

[va-cms-bot]

Cypress Accessibility Violations

/test-data-rerum

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
  Impact: critical
  Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: button[data-proofing-help-title="About 'Main content' field"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"