Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore terraform GCS source #11247

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nguymin4
Copy link

@nguymin4 nguymin4 commented Jan 8, 2025

What are you trying to accomplish?

Related to #5603

Terraform supports GCS bucket as module source https://developer.hashicorp.com/terraform/language/modules/sources#gcs-bucket

But currently dependabot fails with error

Unknown src: gcs::https://www.googleapis.com/storage/v1/modules/foomodule.zip

This PR fixes the Unknown src error but also ignore GCS source as it usually requires authentication and can be somewhat complex. Based on #5603 S3 doesn't seems to work currently either.

Anything you want to highlight for special attention from reviewers?

I had a test for #source_type. However I couldn't find any tests for #source_from

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@nguymin4 nguymin4 requested a review from a team as a code owner January 8, 2025 14:52
@github-actions github-actions bot added the L: terraform Terraform packages label Jan 8, 2025
@nguymin4 nguymin4 force-pushed the nguymin4/terraform-gcs branch from 898ac50 to 857232c Compare January 8, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: terraform Terraform packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant