[TASK] Use php attributes in unit tests

derhansen · Oct 13, 2024 · 26ff842 · 26ff842
1 parent d3c6081
commit 26ff842
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/Tests/Unit/YubikeyAuthServiceTest.php b/Tests/Unit/YubikeyAuthServiceTest.php
@@ -17,6 +17,8 @@
 
 use Derhansen\SfYubikey\Authentication\YubikeyAuthService;
 use Derhansen\SfYubikey\Service\YubikeyService;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\Test;
 use Psr\Log\NullLogger;
 use TYPO3\CMS\Core\Authentication\BackendUserAuthentication;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
@@ -123,10 +125,8 @@ public static function authUserDataProvider(): array
         ];
     }
 
-    /**
-     * @test
-     * @dataProvider authUserDataProvider
-     */
+    #[Test]
+    #[DataProvider('authUserDataProvider')]
     public function authUserReturnsExpectedReturnCode(
         array $userData,
         string $yubikeyOtp,

diff --git a/Tests/Unit/YubikeyServiceTest.php b/Tests/Unit/YubikeyServiceTest.php
@@ -10,6 +10,8 @@
  */
 
 use Derhansen\SfYubikey\Service\YubikeyService;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\Test;
 use TYPO3\CMS\Core\Http\Client\GuzzleClientFactory;
 use TYPO3\CMS\Core\Http\RequestFactory;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
@@ -48,10 +50,8 @@ public static function verifyHmacDataProvider(): array
         ];
     }
 
-    /**
-     * @test
-     * @dataProvider verifyHmacDataProvider
-     */
+    #[Test]
+    #[DataProvider('verifyHmacDataProvider')]
     public function verifyHmacWorksAsExpected(string $response, string $apiKey, bool $expected): void
     {
         // Dummy extension settings