addressing comments

determined-ai · Aug 6, 2024 · ea3136d · ea3136d
1 parent fa3262d
commit ea3136d
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/docs/setup-cluster/k8s/resource-caps.rst b/docs/setup-cluster/k8s/resource-caps.rst
@@ -23,8 +23,7 @@ bindings and resource quotas using either the WebUI or the CLI.
    specify a namespace in the namespace field, the workspace is bound to that namespace. If the
    field is left blank, the workspace is bound to the namespace specified in the
    ``resource_manager.default_namespace`` section of your master configuration (when set), and is
-   otherwise bound to the release namespace. We fall back to the default Kubernetes namespace,
-   "default", during non-helm determined deployments.
+   otherwise bound to the release namespace. For non-helm Determined deployments, it falls back to the default Kubernetes namespace, ``default``.
 
 #. Toggle the "Auto Create Namespace" option on or off. When enabled, the system automatically
    creates a namespace in the cluster, allowing you to edit the resource quota directly in

diff --git a/helm/charts/determined/templates/master-config.yaml b/helm/charts/determined/templates/master-config.yaml
@@ -178,7 +178,7 @@ stringData:
 
     resource_manager:
       type: "kubernetes"
-      {{- if $defaultNamespace := coalesce .Values.resourceManager.defaultNamespace .Release.namespace }}
+      {{- if $defaultNamespace := coalesce .Values.resourceManager.defaultNamespace .Release.Namespace }}
       default_namespace: {{ quote $defaultNamespace }}
       {{- end }}
       {{- if .Values.resourceManager.clusterName }}

diff --git a/master/internal/rm/kubernetesrm/jobs.go b/master/internal/rm/kubernetesrm/jobs.go
@@ -4,7 +4,6 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"log"
 	"math"
 	"os"
 	"path/filepath"
@@ -2404,7 +2403,6 @@ func (j *jobsService) getNamespaceResourceQuota(namespaceName string) (*float64,
 func (j *jobsService) getInitialNamespace() string {
 	releaseNamespace := os.Getenv(ReleaseNamespaceEnvVar)
 	if len(releaseNamespace) > 0 {
-		log.Print("releaseNamespace: ", releaseNamespace)
 		return releaseNamespace
 	}
 	return j.namespace

diff --git a/master/internal/rm/kubernetesrm/kubernetes_resource_manager.go b/master/internal/rm/kubernetesrm/kubernetes_resource_manager.go
@@ -4,7 +4,6 @@ import (
 	"context"
 	"crypto/tls"
 	"fmt"
-	"log"
 	"maps"
 	"slices"
 	"time"
@@ -107,7 +106,7 @@ func New(
 	if err != nil {
 		return nil, err
 	}
-	log.Print(k.config.DefaultNamespace)
+
 	if len(k.config.DefaultNamespace) > 0 {
 		err = k.jobsService.VerifyNamespaceExists(k.config.DefaultNamespace)
 		if err != nil {