Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: license check tests #10216

Merged
merged 2 commits into from
Nov 20, 2024
Merged

fix: license check tests #10216

merged 2 commits into from
Nov 20, 2024

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Nov 19, 2024

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@stoksc stoksc requested a review from mackrorysd November 19, 2024 23:14
@cla-bot cla-bot bot added the cla-signed label Nov 19, 2024
@stoksc stoksc marked this pull request as ready for review November 19, 2024 23:14
@stoksc stoksc requested a review from a team as a code owner November 19, 2024 23:14
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 8cc85ff
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/673d26cb3652db0008d2d9b2

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.89%. Comparing base (b198238) to head (8cc85ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10216      +/-   ##
==========================================
- Coverage   57.84%   53.89%   -3.96%     
==========================================
  Files         752     1257     +505     
  Lines      103521   156487   +52966     
  Branches     3653     3653              
==========================================
+ Hits        59885    84335   +24450     
- Misses      43503    72019   +28516     
  Partials      133      133              
Flag Coverage Δ
backend 46.08% <ø> (+2.27%) ⬆️
harness 67.37% <ø> (ø)
web 54.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/license/license.go 87.50% <ø> (ø)

... and 505 files with indirect coverage changes

---- 🚨 Try these New Features:

@mackrorysd mackrorysd enabled auto-merge (squash) November 20, 2024 00:01
@stoksc stoksc changed the title Fix license check 2 fix: license check tests Nov 20, 2024
@stoksc stoksc disabled auto-merge November 20, 2024 00:51
@stoksc stoksc merged commit 6885a34 into main Nov 20, 2024
76 of 90 checks passed
@stoksc stoksc deleted the fix-license-check-2 branch November 20, 2024 00:51
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
(cherry picked from commit 6885a34)
djanicekpach pushed a commit that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants